Revert "[libclc] replace float remquo with amd ocml implementation"#181443
Merged
Revert "[libclc] replace float remquo with amd ocml implementation"#181443
Conversation
wenju-he
requested review from
arsenm,
frasercrmck,
jhuber6,
kwk and
tstellar
tstellar
approved these changes
Feb 14, 2026
Collaborator
tstellar
left a comment
tstellar
left a comment
There was a problem hiding this comment.
LGTM. The other way to solve this would be to use the old implementation for SPIRV only and the new implementation for the other targets, but that might not be worth the complication.
Contributor
Author
|
Thanks @tstellar |
wenju-he
deleted the
revert-177131-remquo-use-amdgpu-ocml-remquo-float
branch
manasij7479
pushed a commit
to manasij7479/llvm-project
that referenced
this pull request
Feb 18, 2026
…lvm#181443) Reverts llvm#177131 It broke SPIRV target: error in backend: unable to legalize instruction: %88:fid(s32) = G_FCANONICALIZE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #177131
It broke SPIRV target: error in backend: unable to legalize instruction: %88:fid(s32) = G_FCANONICALIZE