[MLIR][NFC] Ignore clang-tidy modernize-use-using check in C code - #180326
Merged
Conversation
Member
|
@llvm/pr-subscribers-mlir Author: Twice (PragmaTwice) ChangesIn the MLIR C API headers, clang-tidy’s Full diff: https://github.com/llvm/llvm-project/pull/180326.diff 1 Files Affected:
diff --git a/mlir/.clang-tidy b/mlir/.clang-tidy
index eb8cbbeb9723c..0d4a4b1214837 100644
--- a/mlir/.clang-tidy
+++ b/mlir/.clang-tidy
@@ -58,3 +58,5 @@ CheckOptions:
value: camelBack
- key: readability-identifier-naming.VariableCase
value: camelBack
+ - key: modernize-use-using.IgnoreExternC
+ value: true
|
makslevental
approved these changes
Feb 9, 2026
makslevental
left a comment
makslevental
left a comment
Contributor
There was a problem hiding this comment.
interesting that this isn't automatically the case given that it can recognize extern "C"
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/19764 Here is the relevant piece of the build log for the reference |
rishabhmadan19
pushed a commit
to rishabhmadan19/llvm-project
that referenced
this pull request
Feb 9, 2026
…lvm#180326) In the MLIR C API headers, clang-tidy’s `modernize-use-using` check reports a large number of type definitions that use `typedef`. In my IDE, this even causes the `typedef` code to be shown as struck through. However, in this case it is clearly not possible to replace them with `using`. This PR suppresses the `modernize-use-using` check for the code inside `extern "C"` blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the MLIR C API headers, clang-tidy’s
modernize-use-usingcheck reports a large number of type definitions that usetypedef. In my IDE, this even causes thetypedefcode to be shown as struck through. However, in this case it is clearly not possible to replace them withusing. This PR suppresses themodernize-use-usingcheck for the code insideextern "C"blocks.