Skip to content

[lldb][test] Rename/remove duplicate methods in API tests - #180250

Merged
DavidSpickett merged 1 commit into
llvm:mainfrom
Michael137:lldb/duplicate-names
Feb 9, 2026
Merged

[lldb][test] Rename/remove duplicate methods in API tests#180250
DavidSpickett merged 1 commit into
llvm:mainfrom
Michael137:lldb/duplicate-names

Conversation

@Michael137

@Michael137 Michael137 commented Feb 6, 2026

Copy link
Copy Markdown
Member

Ran my python script from #97043 over the repo again and there were 2 duplicate test-cases that have been introduced since I last did this.

Also one of the WASM classes had a duplicate method which I just removed.

Ran my python script from llvm#97043 over the repo again and there was 2 duplicate test-cases that have been introduced since I last did this.

Also one of the WASM classes had a duplicate method which I just removed.
@llvmbot

llvmbot commented Feb 6, 2026

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-lldb

Author: Michael Buch (Michael137)

Changes

Ran my python script from #97043 over the repo again and there was 2 duplicate test-cases that have been introduced since I last did this.

Also one of the WASM classes had a duplicate method which I just removed.


Full diff: https://github.com/llvm/llvm-project/pull/180250.diff

3 Files Affected:

  • (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py (+1-1)
  • (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py (+1-1)
  • (modified) lldb/test/API/functionalities/gdb_remote_client/TestWasm.py (-3)
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py
index fc6142ac5d738..b5895792ee4cf 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py
@@ -47,7 +47,7 @@ def do_test(self):
         self.assertEqual(frame.FindVariable("so_greater").summary, "greater")
 
     @add_test_categories(["libc++"])
-    def test_libstdcxx(self):
+    def test_libcxx(self):
         self.build(dictionary={"USE_LIBCPP": 1})
         self.do_test()
 
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py
index f74092ca3a0b8..03ebcba471776 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py
@@ -106,7 +106,7 @@ def test_libstdcxx_debug(self):
         self.do_test()
 
     @add_test_categories(["msvcstl"])
-    def test_libstdcxx(self):
+    def test_msvcstl(self):
         # No flags, because the "msvcstl" category checks that the MSVC STL is used by default.
         self.build()
         self.do_test()
diff --git a/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py b/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
index 73c81efb79347..f025a1f94de54 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
@@ -99,9 +99,6 @@ def qHostInfo(self):
     def QEnableErrorStrings(self):
         return ""
 
-    def qfThreadInfo(self):
-        return "m1,"
-
     def qRegisterInfo(self, index):
         if index == 0:
             return "name:pc;alt-name:pc;bitsize:64;offset:0;encoding:uint;format:hex;set:General Purpose Registers;gcc:16;dwarf:16;generic:pc;"

@Michael137

Copy link
Copy Markdown
Member Author

Maybe its time to consider making this into a github action or make it part of lldb-dotest

@bulbazord bulbazord left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this could be a test in and of itself. :)

@DavidSpickett DavidSpickett changed the title [lldb][test] Rename/remove duplicate methods in API tets [lldb][test] Rename/remove duplicate methods in API tests Feb 9, 2026
@DavidSpickett
DavidSpickett merged commit a07347f into llvm:main Feb 9, 2026
12 checks passed
@Michael137
Michael137 deleted the lldb/duplicate-names branch February 9, 2026 09:56
rishabhmadan19 pushed a commit to rishabhmadan19/llvm-project that referenced this pull request Feb 9, 2026
Ran my python script from
llvm#97043 over the repo again and
there were 2 duplicate test-cases that have been introduced since I last
did this.

Also one of the WASM classes had a duplicate method which I just
removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants