[lldb][test] Rename/remove duplicate methods in API tests - #180250
Merged
Conversation
Ran my python script from llvm#97043 over the repo again and there was 2 duplicate test-cases that have been introduced since I last did this. Also one of the WASM classes had a duplicate method which I just removed.
Member
|
@llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) ChangesRan my python script from #97043 over the repo again and there was 2 duplicate test-cases that have been introduced since I last did this. Also one of the WASM classes had a duplicate method which I just removed. Full diff: https://github.com/llvm/llvm-project/pull/180250.diff 3 Files Affected:
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py
index fc6142ac5d738..b5895792ee4cf 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ordering/TestDataFormatterStdOrdering.py
@@ -47,7 +47,7 @@ def do_test(self):
self.assertEqual(frame.FindVariable("so_greater").summary, "greater")
@add_test_categories(["libc++"])
- def test_libstdcxx(self):
+ def test_libcxx(self):
self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py
index f74092ca3a0b8..03ebcba471776 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterStdVBool.py
@@ -106,7 +106,7 @@ def test_libstdcxx_debug(self):
self.do_test()
@add_test_categories(["msvcstl"])
- def test_libstdcxx(self):
+ def test_msvcstl(self):
# No flags, because the "msvcstl" category checks that the MSVC STL is used by default.
self.build()
self.do_test()
diff --git a/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py b/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
index 73c81efb79347..f025a1f94de54 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
@@ -99,9 +99,6 @@ def qHostInfo(self):
def QEnableErrorStrings(self):
return ""
- def qfThreadInfo(self):
- return "m1,"
-
def qRegisterInfo(self, index):
if index == 0:
return "name:pc;alt-name:pc;bitsize:64;offset:0;encoding:uint;format:hex;set:General Purpose Registers;gcc:16;dwarf:16;generic:pc;"
|
Member
Author
|
Maybe its time to consider making this into a github action or make it part of lldb-dotest |
bulbazord
approved these changes
Feb 6, 2026
bulbazord
left a comment
Member
There was a problem hiding this comment.
Seems like this could be a test in and of itself. :)
JDevlieghere
approved these changes
Feb 6, 2026
DavidSpickett
approved these changes
Feb 9, 2026
rishabhmadan19
pushed a commit
to rishabhmadan19/llvm-project
that referenced
this pull request
Feb 9, 2026
Ran my python script from llvm#97043 over the repo again and there were 2 duplicate test-cases that have been introduced since I last did this. Also one of the WASM classes had a duplicate method which I just removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran my python script from #97043 over the repo again and there were 2 duplicate test-cases that have been introduced since I last did this.
Also one of the WASM classes had a duplicate method which I just removed.