[lldb] [test/FreeBSDKernel] Disable testing#178714
Conversation
The old test suite depends on patches but considering additional features coming in the next few weeks it's inefficient to update them for every PR. Not only that, many parts of the test suite needs to be replaced (e.g. core dump) thus it is reasonable to temporarilyarily disable testing and reenable it once the new features are merged. Signed-off-by: Minsoo Choo <[email protected]>
|
ping @DavidSpickett |
|
@llvm/pr-subscribers-lldb Author: Minsoo Choo (mchoo7) ChangesThe old test suite depends on patches but considering additional features coming in the next few weeks it's inefficient to update them for every PR. Not only that, many parts of the test suite needs to be replaced (e.g. core dump) thus it is reasonable to temporarilyarily disable testing and reenable it once the new features are merged. Full diff: https://github.com/llvm/llvm-project/pull/178714.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/postmortem/FreeBSDKernel/README.rst b/lldb/test/API/functionalities/postmortem/FreeBSDKernel/README.rst
new file mode 100644
index 0000000000000..ab59a3677b73f
--- /dev/null
+++ b/lldb/test/API/functionalities/postmortem/FreeBSDKernel/README.rst
@@ -0,0 +1,5 @@
+FreeBSD Kernel Test Suite
+===============================
+
+This test suite is disabled due to low maintenance and influx of new features.
+A complete test suite will be added once new changes are merged.
|
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
I see what you mean about the patches and so on. Also I now realise these patches aren't going to apply with what you're changing.
I don't think we need to note this tbh, unless you're going on a very long quest (let's say > 6 months) to fix all this. It's not getting in anyone's way but yours and the FreeBSD community, but probably just you for now :)
So you can abandon this PR.
I haven't looked closely at the test implementation but it would certainly help if we can find a way to do this without patching LLDB. But if that's what it takes then I'm ok with it, let's deal with that question later.
|
Abandoning PR |
3 participants
The old test suite depends on patches but considering additional features coming in the next few weeks it's inefficient to update them for every PR. Not only that, many parts of the test suite needs to be replaced (e.g. core dump) thus it is reasonable to temporarilyarily disable testing and reenable it once the new features are merged.