Skip to content

[lldb] Make print delegate to synthetic frames. #178602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzcheeseman wants to merge 1 commit into from
Closed

[lldb] Make print delegate to synthetic frames. #178602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions lldb/source/Commands/CommandObjectDWIMPrint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
maybe_add_hint(output);
result.GetOutputStream() << output;
} else {
llvm::Error error =
valobj.Dump(result.GetOutputStream(), dump_options);
llvm::Error error = valobj.Dump(result.GetOutputStream(), dump_options);
if (error) {
result.AppendError(toString(std::move(error)));
return;
Expand All @@ -155,6 +154,28 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
result.SetStatus(eReturnStatusSuccessFinishResult);
};

// If the frame is synthetic, then we handle all printing through the
// GetValueForVariableExpressionPath. This is so that the synthetic frame has
// the ability to take over anything it needs to.
if (frame && frame->IsSynthetic()) {
VariableSP var_sp;
Status status;
auto valobj_sp = frame->GetValueForVariableExpressionPath(
expr, eval_options.GetUseDynamic(),
StackFrame::eExpressionPathOptionsAllowDirectIVarAccess, var_sp,
status);

// Something failed, print the error and return immediately.
if (!status.Success()) {
result.AppendError(status.AsCString());
return;
}

// Otherwise, simply print the object.
dump_val_object(*valobj_sp);
return;
}

// First, try `expr` as a _limited_ frame variable expression path: only the
// dot operator (`.`) is permitted for this case.
//
Expand Down
Loading