Skip to content

[openmp] Build doxygen in bootstrapping builds #178298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Meinersbur merged 3 commits into from
Jan 29, 2026
Merged

[openmp] Build doxygen in bootstrapping builds #178298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebc0c0b
Build runtimes doxygen
Meinersbur Jan 27, 2026
35036d1
Add TODO comment
Meinersbur Jan 28, 2026
ed5f29a
Also compare to install target
Meinersbur Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions llvm/runtimes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,17 @@ function(runtime_default_target)
# The target libomp-mod is a dependee of check-flang needed to run its
# OpenMP tests
list(APPEND extra_targets "libomp-mod")

# Let the "doxygen" build target also build openmp's doxygen, just like
# "check" and "install" also apply to the runtimes builds.
# TODO: Generalize for all runtimes, but currently openmp is the only
# runtime that has a doxygen target.
if (LLVM_ENABLE_DOXYGEN)
list(APPEND extra_targets "doxygen-openmp")
if (TARGET doxygen)
add_dependencies(doxygen doxygen-openmp)
endif ()
endif ()
Comment on lines +266 to +271
Copy link
Member

@petrhosek petrhosek Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to find a way to generalize this because hardcoding this for every runtime doesn't scale. Ideally, every runtime would provide doxygen-${runtime_name} target similarly to install-${runtime_name} above. That doesn't have to happen in this PR though, but I'd appreciate if you could at least leave a TODO comment here.

Copy link
Member Author

@Meinersbur Meinersbur Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

endif ()

if(LLVM_INCLUDE_TESTS)
Expand All @@ -278,6 +289,7 @@ function(runtime_default_target)
-DLLVM_ENABLE_PROJECTS_USED=${LLVM_ENABLE_PROJECTS_USED}
-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR}
-DLLVM_BUILD_TOOLS=${LLVM_BUILD_TOOLS}
-DLLVM_ENABLE_DOXYGEN=${LLVM_ENABLE_DOXYGEN}
-DCMAKE_C_COMPILER_WORKS=ON
-DCMAKE_CXX_COMPILER_WORKS=ON
-DCMAKE_Fortran_COMPILER_WORKS=ON
Expand Down