Skip to content

[mlir][vector] Wrapping populateFlattenVectorTransferPatterns as a transform pass. #178134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arun-thmn merged 8 commits into from
Feb 9, 2026
Merged

[mlir][vector] Wrapping populateFlattenVectorTransferPatterns as a transform pass. #178134

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a782e6f
Wrapping populateFlattenVectorTransferPatterns as a transform pass
arun-thmn Jan 27, 2026
1887de8
fixing a clang-format error
arun-thmn Jan 27, 2026
32eeea8
added an argument + one test-case for validation
arun-thmn Jan 27, 2026
ad9384d
added an argument + one test-case for validation
arun-thmn Jan 27, 2026
3daa0e9
moving the schedule to vector dialect
arun-thmn Jan 31, 2026
639724a
moved the unit-test into an existing test file
arun-thmn Feb 5, 2026
e642f24
minor formatting changes
arun-thmn Feb 9, 2026
28ef063
moving the width size option
arun-thmn Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mlir/include/mlir/Dialect/X86Vector/TransformOps/X86VectorTransformOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ def ApplyShuffleVectorFMAOpsPatternsOp : Op<Transform_Dialect,
let assemblyFormat = "attr-dict";
}

def ApplyFlattenVectorTransferOpsPatternsOp : Op<Transform_Dialect,
Comment thread
adam-smnk marked this conversation as resolved.
Outdated
"apply_patterns.x86vector.flatten_vector_transfer_ops",
[DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
let description = [{
Comment thread
adam-smnk marked this conversation as resolved.
Outdated
Collect patterns to rewrite contiguous row-major vector.transfer_read or
vector.transfer_write operations to a 1D operation.
}];

let assemblyFormat = "attr-dict";
}


Comment thread
adam-smnk marked this conversation as resolved.
#endif // X86VECTOR_TRANSFORM_OPS

5 changes: 5 additions & 0 deletions mlir/include/mlir/Dialect/X86Vector/Transforms.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ void populateSinkVectorProducerOpsPatterns(RewritePatternSet &patterns);
// grouped with respect to odd/even packed index.
void populateShuffleVectorFMAOpsPatterns(RewritePatternSet &patterns);

// Rewrites contiguous row-major vector.transfer_read or vector.transfer_write
// operations by inserting a memref.collapse_shape on the source,
// transforming the operation to use a 1D source.
void populateFlattenVectorTransferOpsPatterns(RewritePatternSet &patterns);

//===----------------------------------------------------------------------===//
/// Helpers extracted from:
/// - clang/lib/Headers/avxintrin.h
Expand Down
7 changes: 7 additions & 0 deletions mlir/lib/Dialect/X86Vector/TransformOps/X86VectorTransformOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
#include "mlir/Dialect/Vector/IR/VectorOps.h"
#include "mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h"
#include "mlir/Dialect/X86Vector/Transforms.h"
#include "mlir/Dialect/X86Vector/X86VectorDialect.h"

Expand All @@ -21,6 +22,7 @@
using namespace mlir;
using namespace mlir::x86vector;
using namespace mlir::transform;
using namespace mlir::vector;
Comment thread
adam-smnk marked this conversation as resolved.
Outdated

void mlir::transform::ApplyVectorContractToFMAPatternsOp::populatePatterns(
RewritePatternSet &patterns) {
Expand All @@ -47,6 +49,11 @@ void mlir::transform::ApplyShuffleVectorFMAOpsPatternsOp::populatePatterns(
x86vector::populateShuffleVectorFMAOpsPatterns(patterns);
}

void mlir::transform::ApplyFlattenVectorTransferOpsPatternsOp::populatePatterns(
RewritePatternSet &patterns) {
vector::populateFlattenVectorTransferPatterns(patterns);
}

//===----------------------------------------------------------------------===//
// Transform op registration
//===----------------------------------------------------------------------===//
Expand Down