Skip to content

[lldb] [Process/FreeBSDKernel] Select paniced thread automatically #178069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aokblast merged 1 commit into from
Feb 1, 2026
Merged

[lldb] [Process/FreeBSDKernel] Select paniced thread automatically #178069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,13 @@ bool ProcessFreeBSDKernel::DoUpdateThreadList(ThreadList &old_thread_list,
thread_desc += llvm::formatv(" (on CPU {0})", oncpu);
}

ThreadSP thread_sp{
new ThreadFreeBSDKernel(*this, tid, pcb_addr, thread_desc)};
new_thread_list.AddThread(thread_sp);
auto thread =
new ThreadFreeBSDKernel(*this, tid, pcb_addr, thread_desc);

if (tid == dumptid)
thread->SetIsCrashedThread(true);

new_thread_list.AddThread(static_cast<ThreadSP>(thread));
}
}
} else {
Expand Down
11 changes: 10 additions & 1 deletion lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

#include "ThreadFreeBSDKernel.h"

#include "lldb/Target/StopInfo.h"
#include "lldb/Target/Unwind.h"
#include "lldb/Utility/Log.h"

Expand Down Expand Up @@ -82,4 +83,12 @@ ThreadFreeBSDKernel::CreateRegisterContextForFrame(StackFrame *frame) {
return reg_ctx_sp;
}

bool ThreadFreeBSDKernel::CalculateStopInfo() { return false; }
bool ThreadFreeBSDKernel::CalculateStopInfo() {
if (m_is_crashed) {
// Set a stop reason for crashing threads only so that they get selected
// preferentially.
SetStopInfo(StopInfo::CreateStopReasonWithException(*this, "kernel panic"));
return true;
}
return false;
}
3 changes: 3 additions & 0 deletions lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,16 @@ class ThreadFreeBSDKernel : public lldb_private::Thread {
m_thread_name.clear();
}

void SetIsCrashedThread(bool is_crashed) { m_is_crashed = is_crashed; }

protected:
bool CalculateStopInfo() override;

private:
std::string m_thread_name;
lldb::RegisterContextSP m_thread_reg_ctx_sp;
lldb::addr_t m_pcb_addr;
bool m_is_crashed = false;
};

#endif // LLDB_SOURCE_PLUGINS_PROCESS_FREEBSDKERNEL_THREADFREEBSDKERNEL_H
Loading