Skip to content

[AMDGPU][SILoadStoreOptimizer] Fix unused variable warning#177969

Merged
googlewalt merged 2 commits into
llvm:mainfrom
googlewalt:u
Jan 26, 2026
Merged

[AMDGPU][SILoadStoreOptimizer] Fix unused variable warning#177969
googlewalt merged 2 commits into
llvm:mainfrom
googlewalt:u

Conversation

@googlewalt
Copy link
Copy Markdown
Contributor

@googlewalt googlewalt commented Jan 26, 2026

Fix unused variable warning that fires in SILoadStoreOptimizer.cpp when assertions are disabled. On review, we can just delete the whole assert, since it isn't querying the def anymore. Fixes #176816 (13b20e7).

@llvmbot
Copy link
Copy Markdown
Member

llvmbot commented Jan 26, 2026

@llvm/pr-subscribers-backend-amdgpu

Author: Walter Lee (googlewalt)

Changes

Fix unused variable warning that fires n SILoadStoreOptimizer.cpp when assertions are disabled. Fixes #176816 (13b20e7).


Full diff: https://github.com/llvm/llvm-project/pull/177969.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp (+2-2)
diff --git a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
index a3c5fb2fa6ca0..bbee86c603cd2 100644
--- a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
+++ b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
@@ -2282,8 +2282,8 @@ bool SILoadStoreOptimizer::processBaseWithConstOffset64(
   }
 
   // Now extract the base register (which should be a 64-bit VGPR).
-  MachineInstr *BaseDef = MRI->getVRegDef(BaseOp->getReg());
-  assert(BaseDef && "Expected definition for base register");
+  assert(MRI->getVRegDef(BaseOp->getReg()) &&
+         "Expected definition for base register");
   Addr.Base.LoReg = BaseOp->getReg();
   Addr.Base.UseV64Pattern = true;
   return true;

Comment thread llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp Outdated
@googlewalt googlewalt enabled auto-merge (squash) January 26, 2026 15:10
@googlewalt googlewalt disabled auto-merge January 26, 2026 15:19
@googlewalt googlewalt enabled auto-merge (squash) January 26, 2026 15:20
@googlewalt googlewalt merged commit d7666c6 into llvm:main Jan 26, 2026
10 of 11 checks passed
@RyanRio
Copy link
Copy Markdown
Contributor

RyanRio commented Jan 26, 2026

Thanks all

@googlewalt googlewalt deleted the u branch January 29, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants