[AMDGPU][SILoadStoreOptimizer] Fix unused variable warning#177969
Merged
Conversation
…toreOptimizer.cpp Fixes llvm#176816 (13b20e7).
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Walter Lee (googlewalt) ChangesFix unused variable warning that fires n SILoadStoreOptimizer.cpp when assertions are disabled. Fixes #176816 (13b20e7). Full diff: https://github.com/llvm/llvm-project/pull/177969.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
index a3c5fb2fa6ca0..bbee86c603cd2 100644
--- a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
+++ b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
@@ -2282,8 +2282,8 @@ bool SILoadStoreOptimizer::processBaseWithConstOffset64(
}
// Now extract the base register (which should be a 64-bit VGPR).
- MachineInstr *BaseDef = MRI->getVRegDef(BaseOp->getReg());
- assert(BaseDef && "Expected definition for base register");
+ assert(MRI->getVRegDef(BaseOp->getReg()) &&
+ "Expected definition for base register");
Addr.Base.LoReg = BaseOp->getReg();
Addr.Base.UseV64Pattern = true;
return true;
|
hokein
approved these changes
Jan 26, 2026
arsenm
reviewed
Jan 26, 2026
Contributor
|
Thanks all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unused variable warning that fires in SILoadStoreOptimizer.cpp when assertions are disabled. On review, we can just delete the whole assert, since it isn't querying the def anymore. Fixes #176816 (13b20e7).