[OpenMP] Cleanup synchronization primitives#177710
Merged
Conversation
Summary: These shouldn't be so different after we moved away from variants. It's much simpler to define this in-line with a single preprocessor definition. This should be equivalent less a few unnecessary function definitions with the advantage that SPIR-V now has less work to do.
llvmbot
added
openmp:libomp
shiltian
reviewed
Jan 24, 2026
| #ifdef __NVPTX__ | ||
| __nvvm_membar_sys(); | ||
| #else | ||
| __scoped_atomic_thread_fence(Ordering, atomic::system); |
Contributor
There was a problem hiding this comment.
thse builtins are not gonna be lowered on nvptx?
Contributor
Author
There was a problem hiding this comment.
Someone in the NVPTX backend needs to work on handling memory scopes properly on all the builtins.
sarnex
approved these changes
Jan 26, 2026
Member
sarnex
left a comment
sarnex
left a comment
There was a problem hiding this comment.
idea lgtm but not an expert in these functions
ronlieb
added a commit
to ROCm/llvm-project
that referenced
this pull request
Jan 27, 2026
This reverts commit 5597903.
ronlieb
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jan 28, 2026
Summary: These shouldn't be so different after we moved away from variants. It's much simpler to define this in-line with a single preprocessor definition. This should be equivalent less a few unnecessary function definitions with the advantage that SPIR-V now has less work to do.
ronlieb
added a commit
to ROCm/llvm-project
that referenced
this pull request
Jan 28, 2026
Summary: These shouldn't be so different after we moved away from variants. It's much simpler to define this in-line with a single preprocessor definition. This should be equivalent less a few unnecessary function definitions with the advantage that SPIR-V now has less work to do. Co-authored-by: Joseph Huber <huberjn@outlook.com>
stomfaig
pushed a commit
to stomfaig/llvm-project
that referenced
this pull request
Jan 28, 2026
Summary: These shouldn't be so different after we moved away from variants. It's much simpler to define this in-line with a single preprocessor definition. This should be equivalent less a few unnecessary function definitions with the advantage that SPIR-V now has less work to do.
sshrestha-aa
pushed a commit
to sshrestha-aa/llvm-project
that referenced
this pull request
Feb 4, 2026
Summary: These shouldn't be so different after we moved away from variants. It's much simpler to define this in-line with a single preprocessor definition. This should be equivalent less a few unnecessary function definitions with the advantage that SPIR-V now has less work to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
These shouldn't be so different after we moved away from variants. It's
much simpler to define this in-line with a single preprocessor
definition. This should be equivalent less a few unnecessary function
definitions with the advantage that SPIR-V now has less work to do.