[lldb] Fix test_chained_frame_providers on 32-bit Arm#177668
Merged
[lldb] Fix test_chained_frame_providers on 32-bit Arm#177668
Conversation
PC addresses must always be 16-bit aligned on 32-bit Arm CPUs. Fixes llvm#177666
Member
|
@llvm/pr-subscribers-lldb Author: Leandro Lupori (luporl) ChangesPC addresses must always be 16-bit aligned on 32-bit Arm CPUs. Fixes #177666 Full diff: https://github.com/llvm/llvm-project/pull/177668.diff 2 Files Affected:
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/TestScriptedFrameProvider.py b/lldb/test/API/functionalities/scripted_frame_provider/TestScriptedFrameProvider.py
index ceca64a450686..964d213b16887 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/TestScriptedFrameProvider.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/TestScriptedFrameProvider.py
@@ -706,7 +706,7 @@ def test_chained_frame_providers(self):
"baz",
"Frame 0 should be 'baz' from last provider in chain",
)
- self.assertEqual(frame0.GetPC(), 0xBAD)
+ self.assertEqual(frame0.GetPC(), 0xBAC)
frame1 = thread.GetFrameAtIndex(1)
self.assertIsNotNone(frame1)
@@ -715,7 +715,7 @@ def test_chained_frame_providers(self):
"bar",
"Frame 1 should be 'bar' from second provider in chain",
)
- self.assertEqual(frame1.GetPC(), 0xBAB)
+ self.assertEqual(frame1.GetPC(), 0xBAA)
frame2 = thread.GetFrameAtIndex(2)
self.assertIsNotNone(frame2)
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/test_frame_providers.py b/lldb/test/API/functionalities/scripted_frame_provider/test_frame_providers.py
index e97d11f173045..6233041f68a51 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/test_frame_providers.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/test_frame_providers.py
@@ -427,7 +427,7 @@ def get_priority():
def get_frame_at_index(self, index):
if index == 0:
# Return synthetic "bar" frame
- return CustomScriptedFrame(self.thread, 0, 0xBAB, "bar")
+ return CustomScriptedFrame(self.thread, 0, 0xBAA, "bar")
elif index - 1 < len(self.input_frames):
# Pass through input frames (shifted by 1)
return index - 1
@@ -453,7 +453,7 @@ def get_priority():
def get_frame_at_index(self, index):
if index == 0:
# Return synthetic "baz" frame
- return CustomScriptedFrame(self.thread, 0, 0xBAD, "baz")
+ return CustomScriptedFrame(self.thread, 0, 0xBAC, "baz")
elif index - 1 < len(self.input_frames):
# Pass through input frames (shifted by 1)
return index - 1
|
Harrish92
pushed a commit
to Harrish92/llvm-project
that referenced
this pull request
Jan 24, 2026
PC addresses must always be 16-bit aligned on 32-bit Arm CPUs. Fixes llvm#177666
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Jan 29, 2026
PC addresses must always be 16-bit aligned on 32-bit Arm CPUs. Fixes llvm#177666
sshrestha-aa
pushed a commit
to sshrestha-aa/llvm-project
that referenced
this pull request
Feb 4, 2026
PC addresses must always be 16-bit aligned on 32-bit Arm CPUs. Fixes llvm#177666
c-rhodes
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 9, 2026
PC addresses must always be 16-bit aligned on 32-bit Arm CPUs. Fixes llvm#177666 (cherry picked from commit cd70e2d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PC addresses must always be 16-bit aligned on 32-bit Arm CPUs.
Fixes #177666