[LVI] Fix the type when inferring nonnull from a dereferenceable attribute bundle#177562
Merged
philnik777 merged 1 commit intollvm:mainfrom Jan 23, 2026
Merged
[LVI] Fix the type when inferring nonnull from a dereferenceable attribute bundle#177562philnik777 merged 1 commit intollvm:mainfrom
philnik777 merged 1 commit intollvm:mainfrom
Conversation
llvmbot
added
the
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis Author: Nikolas Klauser (philnik777) ChangesFull diff: https://github.com/llvm/llvm-project/pull/177562.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/LazyValueInfo.cpp b/llvm/lib/Analysis/LazyValueInfo.cpp
index 0bdd158970dc7..b4d64536a5aca 100644
--- a/llvm/lib/Analysis/LazyValueInfo.cpp
+++ b/llvm/lib/Analysis/LazyValueInfo.cpp
@@ -854,7 +854,7 @@ void LazyValueInfoImpl::intersectAssumeOrGuardBlockValueConstantRange(
if (auto *CI = dyn_cast<ConstantInt>(RK.IRArgValue);
CI && !CI->isZero())
BBLV = BBLV.intersect(ValueLatticeElement::getNot(
- Constant::getNullValue(RK.IRArgValue->getType())));
+ Constant::getNullValue(RK.WasOn->getType())));
break;
default:
|
Contributor
Author
|
I think this should fix #176734 (comment), but I'm not sure how to test this. Any hints would be appreciated. |
Contributor
I'm not sure it's worthwhile to track down when exactly the type ends up mattering, but something we could do instead is to add an additional consistency assertion to make sure that the type of the value and the type of the value lattice (for constant lattice values) match somewhere. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/19768 Here is the relevant piece of the build log for the reference |
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Jan 29, 2026
sshrestha-aa
pushed a commit
to sshrestha-aa/llvm-project
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.