Skip to content

[AMDGPU][Scheduler] Make finalizeGCNRegion an overridable hook (NFC) #177199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-rami merged 1 commit into from
Jan 30, 2026
Merged

[AMDGPU][Scheduler] Make finalizeGCNRegion an overridable hook (NFC) #177199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ void GCNSchedStrategy::initialize(ScheduleDAGMI *DAG) {
VGPRCriticalLimit -= std::min(VGPRLimitBias + ErrorMargin, VGPRCriticalLimit);
SGPRExcessLimit -= std::min(SGPRLimitBias + ErrorMargin, SGPRExcessLimit);
VGPRExcessLimit -= std::min(VGPRLimitBias + ErrorMargin, VGPRExcessLimit);

LLVM_DEBUG(dbgs() << "VGPRCriticalLimit = " << VGPRCriticalLimit
<< ", VGPRExcessLimit = " << VGPRExcessLimit
<< ", SGPRCriticalLimit = " << SGPRCriticalLimit
Expand Down Expand Up @@ -1163,6 +1162,8 @@ void GCNScheduleDAGMILive::runSchedStages() {

ScheduleDAGMILive::schedule();
Stage->finalizeGCNRegion();
Stage->advanceRegion();
exitRegion();
}

Stage->finalizeGCNSchedStage();
Expand Down Expand Up @@ -1473,9 +1474,6 @@ void GCNSchedStage::finalizeGCNRegion() {
if (DAG.RegionsWithIGLPInstrs[RegionIdx] &&
StageID != GCNSchedStageID::UnclusteredHighRPReschedule)
SavedMutations.swap(DAG.Mutations);

DAG.exitRegion();
advanceRegion();
}

void GCNSchedStage::checkScheduling() {
Expand Down
6 changes: 3 additions & 3 deletions llvm/lib/Target/AMDGPU/GCNSchedStrategy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,12 +367,12 @@ class GCNSchedStage {
// be skipped.
virtual bool initGCNRegion();

// Finalize state after scheduling a region.
virtual void finalizeGCNRegion();

// Track whether a new region is also a new MBB.
void setupNewBlock();

// Finalize state after scheudling a region.
void finalizeGCNRegion();

// Check result of scheduling.
void checkScheduling();

Expand Down
Loading