Skip to content

[CMake] Move RTTI flag calculation to AddLLVM.cmake#175553

Merged
aengelke merged 2 commits intollvm:mainfrom
aengelke:fix-cmake-llvm-config2
Jan 12, 2026
Merged

[CMake] Move RTTI flag calculation to AddLLVM.cmake#175553
aengelke merged 2 commits intollvm:mainfrom
aengelke:fix-cmake-llvm-config2

Conversation

@aengelke
Copy link
Contributor

This should help users who use AddLLVM.cmake without HandleLLVMOptions. Note that remains MSVC is unlikely to work.

Follow up of #174084.

This should help users who use AddLLVM.cmake without HandleLLVMOptions.
Note that remains MSVC is unlikely to work.
@aengelke aengelke requested a review from nikic January 12, 2026 14:54
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Jan 12, 2026
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Nikita Popov <github@npopov.com>
@aengelke aengelke enabled auto-merge (squash) January 12, 2026 15:22
@aengelke aengelke merged commit 3c45c54 into llvm:main Jan 12, 2026
9 of 10 checks passed
@dcaballe
Copy link
Contributor

Thanks!

@aengelke aengelke deleted the fix-cmake-llvm-config2 branch January 13, 2026 07:51
Priyanshu3820 pushed a commit to Priyanshu3820/llvm-project that referenced this pull request Jan 18, 2026
This should help users who use AddLLVM.cmake without HandleLLVMOptions.
Note that remains MSVC is unlikely to work.

Follow up of llvm#174084.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake Build system in general and CMake in particular

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants