Skip to content

[MLIR] Fix crash in RemoveDeadValues when terminator lacks RegionBranchTerminatorOpInterface #175300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nataliakokoromyti wants to merge 1 commit into from
Closed

[MLIR] Fix crash in RemoveDeadValues when terminator lacks RegionBranchTerminatorOpInterface #175300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions mlir/lib/Transforms/RemoveDeadValues.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,10 @@ static void processRegionBranchOp(RegionBranchOpInterface regionBranchOp,
if (region.empty())
continue;
// TODO: this isn't correct in face of multiple terminators.
auto terminator = cast<RegionBranchTerminatorOpInterface>(
auto terminator = dyn_cast<RegionBranchTerminatorOpInterface>(
region.front().getTerminator());
if (!terminator)
continue;
nonForwardedRets[terminator] =
BitVector(terminator->getNumOperands(), true);
for (const RegionSuccessor &successor : getSuccessors(terminator)) {
Expand All @@ -498,11 +500,17 @@ static void processRegionBranchOp(RegionBranchOpInterface regionBranchOp,
DenseMap<Region *, BitVector> &argsToKeep, Region *region = nullptr) {
Operation *terminator =
region ? region->front().getTerminator() : nullptr;
RegionBranchPoint point =
auto terminatorIface =
terminator
? RegionBranchPoint(
cast<RegionBranchTerminatorOpInterface>(terminator))
: RegionBranchPoint::parent();
? dyn_cast<RegionBranchTerminatorOpInterface>(terminator)
: nullptr;
// If terminator doesn't implement RegionBranchTerminatorOpInterface,
// we can't analyze it, so skip.
if (terminator && !terminatorIface)
return;
RegionBranchPoint point =
terminatorIface ? RegionBranchPoint(terminatorIface)
: RegionBranchPoint::parent();

for (const RegionSuccessor &successor : getSuccessors(point)) {
Region *successorRegion = successor.getSuccessor();
Expand Down Expand Up @@ -566,8 +574,10 @@ static void processRegionBranchOp(RegionBranchOpInterface regionBranchOp,
for (Region &region : regionBranchOp->getRegions()) {
if (region.empty())
continue;
auto terminator = cast<RegionBranchTerminatorOpInterface>(
auto terminator = dyn_cast<RegionBranchTerminatorOpInterface>(
region.front().getTerminator());
if (!terminator)
continue;
for (const RegionSuccessor &successor : getSuccessors(terminator)) {
Region *successorRegion = successor.getSuccessor();
for (auto [opOperand, input] :
Expand Down