Skip to content

[NFC][LLVM] Minor namespace cleanup in llvm-dis.cpp #175254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurahul merged 1 commit into from
Jan 12, 2026
Merged

[NFC][LLVM] Minor namespace cleanup in llvm-dis.cpp #175254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions llvm/tools/llvm-dis/llvm-dis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ static cl::opt<bool> PrintThinLTOIndexOnly(
cl::desc("Only read thinlto index and print the index as LLVM assembly."),
cl::init(false), cl::Hidden, cl::cat(DisCategory));

namespace {

static void printDebugLoc(const DebugLoc &DL, formatted_raw_ostream &OS) {
OS << DL.getLine() << ":" << DL.getCol();
if (DILocation *IDL = DL.getInlinedAt()) {
OS << "@";
printDebugLoc(IDL, OS);
}
}

namespace {
class CommentWriter : public AssemblyAnnotationWriter {
private:
bool canSafelyAccessUses(const Value &V) {
Expand All @@ -117,6 +117,7 @@ class CommentWriter : public AssemblyAnnotationWriter {
OS << "; [#uses=" << F->getNumUses() << ']'; // Output # uses
OS << '\n';
}

void printInfoComment(const Value &V, formatted_raw_ostream &OS) override {
if (!canSafelyAccessUses(V))
return;
Expand Down Expand Up @@ -165,7 +166,7 @@ struct LLVMDisDiagnosticHandler : public DiagnosticHandler {
return true;
}
};
} // end anon namespace
} // namespace

static ExitOnError ExitOnErr;

Expand Down