Skip to content

Conversation

@jurahul
Copy link
Contributor

@jurahul jurahul commented Jan 9, 2026

Remove redundant empty checks for prefix/suffix strings and flush() for raw_string_ostream.

Remove redundant empty checks for prefix/suffix strings and flush()
for raw_string_ostream.
@jurahul jurahul requested a review from kuhar January 9, 2026 21:19
@jurahul jurahul marked this pull request as ready for review January 9, 2026 21:20
@llvmbot
Copy link
Member

llvmbot commented Jan 9, 2026

@llvm/pr-subscribers-llvm-support

Author: Rahul Joshi (jurahul)

Changes

Remove redundant empty checks for prefix/suffix strings and flush() for raw_string_ostream.


Full diff: https://github.com/llvm/llvm-project/pull/175237.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/InterleavedRange.h (+2-5)
diff --git a/llvm/include/llvm/Support/InterleavedRange.h b/llvm/include/llvm/Support/InterleavedRange.h
index ce7cac98bcdd4..2c7b87036f4d1 100644
--- a/llvm/include/llvm/Support/InterleavedRange.h
+++ b/llvm/include/llvm/Support/InterleavedRange.h
@@ -44,11 +44,9 @@ template <typename Range> class InterleavedRange {
 
   template <typename OStream>
   friend OStream &operator<<(OStream &OS, const InterleavedRange &Interleaved) {
-    if (!Interleaved.Prefix.empty())
-      OS << Interleaved.Prefix;
+    OS << Interleaved.Prefix;
     llvm::interleave(Interleaved.TheRange, OS, Interleaved.Separator);
-    if (!Interleaved.Suffix.empty())
-      OS << Interleaved.Suffix;
+    OS << Interleaved.Suffix;
     return OS;
   }
 
@@ -56,7 +54,6 @@ template <typename Range> class InterleavedRange {
     std::string Result;
     raw_string_ostream Stream(Result);
     Stream << *this;
-    Stream.flush();
     return Result;
   }
 

@jurahul jurahul merged commit e6691b0 into llvm:main Jan 12, 2026
14 checks passed
@jurahul jurahul deleted the nfc_interveleaved_cleanup branch January 12, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants