Skip to content

[clang-doc] Don't serialize non-existant locations in HTML #174887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelez7 merged 1 commit into from
Jan 9, 2026
Merged

[clang-doc] Don't serialize non-existant locations in HTML #174887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang-tools-extra/clang-doc/assets/function-template.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,7 @@
{{>Comments}}
</div>
{{/Description}}
<p>Defined at line {{Location.LineNumber}} of file {{Location.Filename}}</p>
{{#Location}}
<p>Defined at line {{LineNumber}} of file {{Filename}}</p>
{{/Location}}
</div>
1 change: 0 additions & 1 deletion clang-tools-extra/test/clang-doc/json/class.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ struct MyClass {
// HTML-NEXT: <div>
// HTML-NEXT: <div id="{{([0-9A-F]{40})}}" class="delimiter-container">
// HTML-NEXT: <pre><code class="language-cpp code-clang-doc">int protectedMethod ()</code></pre>
// HTML-NEXT: <p>Defined at line of file </p>
// HTML-NEXT: </div>
// HTML-NEXT: </div>
// HTML-NEXT: </section>
Expand Down
2 changes: 0 additions & 2 deletions clang-tools-extra/test/clang-doc/templates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ void ParamPackFunction(T... args);

// HTML: <pre><code class="language-cpp code-clang-doc">template &lt;class... T&gt;</code></pre>
// HTML-NEXT: <pre><code class="language-cpp code-clang-doc">void ParamPackFunction (T... args)</code></pre>
// COM: FIXME: Omit defined line if not defined, or emit declaration line.
// HTML-NEXT: <p>Defined at line of file </p>
// HTML-NEXT: </div>

template <typename T, int U = 1>
Expand Down