[mlir][CAPI][transform] fix linker after #82190 #174866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir Author: Maksim Levental (makslevental) ChangesFull diff: https://github.com/llvm/llvm-project/pull/174866.diff 1 Files Affected:
diff --git a/mlir/lib/CAPI/Dialect/CMakeLists.txt b/mlir/lib/CAPI/Dialect/CMakeLists.txt
index 83bc6ff38852c..d5adda6dc00ea 100644
--- a/mlir/lib/CAPI/Dialect/CMakeLists.txt
+++ b/mlir/lib/CAPI/Dialect/CMakeLists.txt
@@ -465,6 +465,7 @@ add_mlir_upstream_c_api_library(MLIRCAPITransformDialect
LINK_LIBS PUBLIC
MLIRCAPIIR
MLIRTransformDialect
+ MLIRTransformDialectTransforms
)
add_mlir_upstream_c_api_library(MLIRCAPITransformDialectTransforms
|
Contributor
Author
ftynse
approved these changes
Jan 7, 2026
makslevental
force-pushed
the
users/makslevental/fixcapitransform
branch
from
b085a0c to
2245cd4
Compare
makslevental
force-pushed
the
users/makslevental/fixcapitransform
branch
from
2245cd4 to
1ce47f8
Compare
Contributor
|
Thanks for the fix! It seems there is still a linker error for our bot. Would you mind taking a look? Thanks! |
Contributor
Author
I would love to know how these are slipping through both pre-commit and various other bots... but okay let me do that one as well. |
Contributor
Author
|
fix here #174876 |
Contributor
|
Thanks again for the quick fix! |
kshitijvp
pushed a commit
to kshitijvp/llvm-project
that referenced
this pull request
Jan 9, 2026
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.