CodeGen: Remove denormal mode from TargetOptions#174285
Merged
Conversation
This doesn't appear to be used anywhere, and is a per-function property.
arsenm
added
the
clang:codegen
Graphite App
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arsenm
requested review from
aemerson,
dtcxzyw,
jcranmer-intel and
paperchalice
Member
|
@llvm/pr-subscribers-clang-codegen Author: Matt Arsenault (arsenm) ChangesThis doesn't appear to be used anywhere, and is a Full diff: https://github.com/llvm/llvm-project/pull/174285.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Target/TargetOptions.h b/llvm/include/llvm/Target/TargetOptions.h
index 0312515d11798..7af50691ec0e5 100644
--- a/llvm/include/llvm/Target/TargetOptions.h
+++ b/llvm/include/llvm/Target/TargetOptions.h
@@ -140,8 +140,7 @@ class TargetOptions {
DebugStrictDwarf(false), Hotpatch(false),
PPCGenScalarMASSEntries(false), JMCInstrument(false),
EnableCFIFixup(false), MisExpect(false), XCOFFReadOnlyPointers(false),
- VerifyArgABICompliance(true),
- FPDenormalMode(DenormalMode::IEEE, DenormalMode::IEEE) {}
+ VerifyArgABICompliance(true) {}
/// DisableFramePointerElim - This returns true if frame pointer elimination
/// optimization should be disabled for the given machine function.
@@ -413,25 +412,7 @@ class TargetOptions {
/// Vector math library to use.
VectorLibrary VecLib = VectorLibrary::NoLibrary;
-private:
- /// Flushing mode to assume in default FP environment.
- DenormalMode FPDenormalMode;
-
- /// Flushing mode to assume in default FP environment, for float/vector of
- /// float.
- DenormalMode FP32DenormalMode;
-
public:
- void setFPDenormalMode(DenormalMode Mode) { FPDenormalMode = Mode; }
-
- void setFP32DenormalMode(DenormalMode Mode) { FP32DenormalMode = Mode; }
-
- DenormalMode getRawFPDenormalMode() const { return FPDenormalMode; }
-
- DenormalMode getRawFP32DenormalMode() const { return FP32DenormalMode; }
-
- LLVM_ABI DenormalMode getDenormalMode(const fltSemantics &FPType) const;
-
/// What exception model to use
ExceptionHandling ExceptionModel = ExceptionHandling::None;
diff --git a/llvm/lib/CodeGen/CommandFlags.cpp b/llvm/lib/CodeGen/CommandFlags.cpp
index 8f92ee30e221a..ef5eabccab480 100644
--- a/llvm/lib/CodeGen/CommandFlags.cpp
+++ b/llvm/lib/CodeGen/CommandFlags.cpp
@@ -601,11 +601,6 @@ codegen::InitTargetOptionsFromCodeGenFlags(const Triple &TheTriple) {
Options.NoSignedZerosFPMath = getEnableNoSignedZerosFPMath();
Options.NoTrappingFPMath = getEnableNoTrappingFPMath();
- DenormalMode::DenormalModeKind DenormKind = getDenormalFPMath();
-
- // FIXME: Should have separate input and output flags
- Options.setFPDenormalMode(DenormalMode(DenormKind, DenormKind));
-
Options.HonorSignDependentRoundingFPMathOption =
getEnableHonorSignDependentRoundingFPMath();
if (getFloatABIForCalls() != FloatABI::Default)
|
dtcxzyw
approved these changes
Jan 4, 2026
arsenm
deleted the
users/arsenm/codegen/remove-targetoptions-denormal-mode
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/20992 Here is the relevant piece of the build log for the reference |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jan 6, 2026
This doesn't appear to be used anywhere, and is a per-function property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't appear to be used anywhere, and is a
per-function property.