Skip to content

Comments

[SelectionDAG] Fix return type of JUMP_TABLE_DEBUG_INFO node#174228

Merged
s-barannikov merged 1 commit intollvm:mainfrom
s-barannikov:sdnode/jump-table-debug-info-return-type
Jan 2, 2026
Merged

[SelectionDAG] Fix return type of JUMP_TABLE_DEBUG_INFO node#174228
s-barannikov merged 1 commit intollvm:mainfrom
s-barannikov:sdnode/jump-table-debug-info-return-type

Conversation

@s-barannikov
Copy link
Contributor

The node has a chain result, not a glue.

Extracted from #168421.

The node has a chain result, not a glue.
@s-barannikov s-barannikov requested a review from topperc January 2, 2026 18:18
@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label Jan 2, 2026
@llvmbot
Copy link
Member

llvmbot commented Jan 2, 2026

@llvm/pr-subscribers-llvm-selectiondag

Author: Sergei Barannikov (s-barannikov)

Changes

The node has a chain result, not a glue.

Extracted from #168421.


Full diff: https://github.com/llvm/llvm-project/pull/174228.diff

1 Files Affected:

  • (modified) llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (+1-1)
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index b899dd91b06a6..da43ae3b28d70 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -1970,7 +1970,7 @@ SDValue SelectionDAG::getJumpTable(int JTI, EVT VT, bool isTarget,
 SDValue SelectionDAG::getJumpTableDebugInfo(int JTI, SDValue Chain,
                                             const SDLoc &DL) {
   EVT PTy = getTargetLoweringInfo().getPointerTy(getDataLayout());
-  return getNode(ISD::JUMP_TABLE_DEBUG_INFO, DL, MVT::Glue, Chain,
+  return getNode(ISD::JUMP_TABLE_DEBUG_INFO, DL, MVT::Other, Chain,
                  getTargetConstant(static_cast<uint64_t>(JTI), DL, PTy, true));
 }
 

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-barannikov s-barannikov enabled auto-merge (squash) January 2, 2026 18:39
@s-barannikov s-barannikov merged commit 501aa37 into llvm:main Jan 2, 2026
11 of 12 checks passed
@s-barannikov s-barannikov deleted the sdnode/jump-table-debug-info-return-type branch January 3, 2026 12:46
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:SelectionDAG SelectionDAGISel as well

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants