Skip to content

Revert "[llvm][clang] Enable IO sandbox for assert builds"#173074

Merged
jansvoboda11 merged 1 commit intomainfrom
revert-171935-sandboxing-enablement
Dec 19, 2025
Merged

Revert "[llvm][clang] Enable IO sandbox for assert builds"#173074
jansvoboda11 merged 1 commit intomainfrom
revert-171935-sandboxing-enablement

Conversation

@jansvoboda11
Copy link
Contributor

Reverts #171935.

The sandbox infrastructure was (incorrectly) only implemented for clang -cc1 jobs created by the driver in #165350. Direct clang -cc1 invocations had the sandbox disabled. This reduced the coverage of our test suite and lead to sandbox violations for people using asserts-enabled Clang.

This PR temporarily disables the sandbox for asserts builds, so that we have time to investigate and fix sandbox violations for direct clang -cc1 commands and re-enable for asserts builds at a later time.

@jansvoboda11 jansvoboda11 enabled auto-merge (squash) December 19, 2025 18:38
@jansvoboda11 jansvoboda11 merged commit 56c0173 into main Dec 19, 2025
10 of 11 checks passed
@jansvoboda11 jansvoboda11 deleted the revert-171935-sandboxing-enablement branch December 19, 2025 18:58
@llvm-ci
Copy link

llvm-ci commented Dec 19, 2025

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-gcc-ubuntu running on sie-linux-worker3 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/29153

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Preprocessor/c99-6_10_3_4_p6.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/lib/clang/22/include -nostdsysteminc -E /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c | /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck -strict-whitespace /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# executed command: /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/lib/clang/22/include -nostdsysteminc -E /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# .---command stderr------------
# | /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c:7:57: warning: backslash and newline separated by space [-Wbackslash-newline-escape]
# |     7 | #define debug(s, t) printf("x" # s "= %d, x" # t "= s" \ 
# |       |                                                         ^
# | 1 warning generated.
# `-----------------------------
# executed command: /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck -strict-whitespace /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# .---command stderr------------
# | �[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c:24:11: �[0m�[0;1;31merror: �[0m�[1mCHECK: expected string not found in input
�[0m# | �[1m�[0m// CHECK: include "vers2.h"
# | �[0;1;32m          ^
�[0m# | �[0;1;32m�[0m�[1m<stdin>:10:62: �[0m�[0;1;30mnote: �[0m�[1mscanning from here
�[0m# | �[1m�[0mfputs("strncmp(\"abc\\0d\" \"abc\", '\\4') == 0" ": @\n", s);
# | �[0;1;32m                                                             ^
�[0m# | �[0;1;32m�[0m�[1m<stdin>:12:1: �[0m�[0;1;30mnote: �[0m�[1mpossible intended match here
�[0m# | �[1m�[0minclude "vers2 .h"
# | �[0;1;32m^
�[0m# | �[0;1;32m�[0m
# | Input file: <stdin>
# | Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# | �[1m�[0m�[0;1;30m            1: �[0m�[1m�[0;1;46m# 1 "/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c" �[0m
# | �[0;1;30m            2: �[0m�[1m�[0;1;46m# 1 "<built-in>" 1 �[0m
# | �[0;1;30m            3: �[0m�[1m�[0;1;46m# 1 "<built-in>" 3 �[0m
# | �[0;1;30m            4: �[0m�[1m�[0;1;46m# 388 "<built-in>" 3 �[0m
# | �[0;1;30m            5: �[0m�[1m�[0;1;46m# 1 "<command line>" 1 �[0m
# | �[0;1;30m            6: �[0m�[1m�[0;1;46m# 1 "<built-in>" 2 �[0m
# | �[0;1;30m            7: �[0m�[1m�[0;1;46m# 1 "/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c" 2 �[0m
# | �[0;1;30m            8: �[0m�[1m�[0;1;46m# 14 "/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c" �[0m
# | �[0;1;30m            9: �[0m�[1m�[0;1;46m�[0mprintf("x" "1" "= %d, x" "2" "= s" x1, x2);�[0;1;46m �[0m
# | �[0;1;32mcheck:22       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;30m           10: �[0m�[1m�[0;1;46m�[0mfputs("strncmp(\"abc\\0d\" \"abc\", '\\4') == 0" ": @\n", s);�[0;1;46m �[0m
# | �[0;1;32mcheck:23       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;31mcheck:24'0                                                                  X error: no match found
�[0m# | �[0;1;31m�[0m�[0;1;30m           11: �[0m�[1m�[0;1;46m �[0m
# | �[0;1;31mcheck:24'0     ~
�[0m# | �[0;1;31m�[0m�[0;1;30m           12: �[0m�[1m�[0;1;46minclude "vers2 .h" �[0m
# | �[0;1;31mcheck:24'0     ~~~~~~~~~~~~~~~~~~~
...

@llvm-ci
Copy link

llvm-ci commented Dec 19, 2025

LLVM Buildbot has detected a new failure on builder llvm-clang-win-x-armv7l running on as-builder-1 while building llvm at step 10 "test-check-clang".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/38/builds/6941

Here is the relevant piece of the build log for the reference
Step 10 (test-check-clang) failure: Test just built components: check-clang completed (failure)
******************** TEST 'Clang :: Parser/ms-square-bracket-attributes.mm' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\buildbot\as-builder-1\x-armv7l\build\bin\clang.exe -cc1 -internal-isystem C:\buildbot\as-builder-1\x-armv7l\build\lib\clang\22\include -nostdsysteminc -fsyntax-only -std=c++14 -verify -fms-extensions C:\buildbot\as-builder-1\x-armv7l\llvm-project\clang\test\Parser\ms-square-bracket-attributes.mm -Wno-deprecated-declarations
# executed command: 'c:\buildbot\as-builder-1\x-armv7l\build\bin\clang.exe' -cc1 -internal-isystem 'C:\buildbot\as-builder-1\x-armv7l\build\lib\clang\22\include' -nostdsysteminc -fsyntax-only -std=c++14 -verify -fms-extensions 'C:\buildbot\as-builder-1\x-armv7l\llvm-project\clang\test\Parser\ms-square-bracket-attributes.mm' -Wno-deprecated-declarations
# .---command stderr------------
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File C:\buildbot\as-builder-1\x-armv7l\llvm-project\clang\test\Parser\ms-square-bracket-attributes.mm Line 80: uuid attribute contains a malformed GUID
# |   File C:\buildbot\as-builder-1\x-armv7l\llvm-project\clang\test\Parser\ms-square-bracket-attributes.mm Line 124: cannot call operator __uuidof on a type with no GUID
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

********************


@llvm-ci
Copy link

llvm-ci commented Dec 20, 2025

LLVM Buildbot has detected a new failure on builder ppc64le-mlir-rhel-clang running on ppc64le-mlir-rhel-test while building llvm at step 6 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/129/builds/35343

Here is the relevant piece of the build log for the reference
Step 6 (test-build-check-mlir-build-only-check-mlir) failure: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
...
PASS: MLIR-Unit :: Dialect/SparseTensor/./MLIRSparseTensorTests/95/210 (3761 of 3770)
PASS: MLIR-Unit :: Dialect/SparseTensor/./MLIRSparseTensorTests/90/210 (3762 of 3770)
PASS: MLIR-Unit :: Dialect/SparseTensor/./MLIRSparseTensorTests/76/210 (3763 of 3770)
PASS: MLIR-Unit :: Dialect/SparseTensor/./MLIRSparseTensorTests/94/210 (3764 of 3770)
PASS: MLIR-Unit :: Dialect/SparseTensor/./MLIRSparseTensorTests/93/210 (3765 of 3770)
PASS: MLIR :: Pass/action-logging-filter.mlir (3766 of 3770)
PASS: MLIR :: Pass/crash-recovery.mlir (3767 of 3770)
PASS: MLIR :: mlir-runner/utils.mlir (3768 of 3770)
PASS: MLIR :: mlir-tblgen/rewriter-errors.td (3769 of 3770)
PASS: MLIR :: Pass/pipeline-options-parsing.mlir (3770 of 3770)
command timed out: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=2343.890389

valadaptive pushed a commit to valadaptive/llvm-project that referenced this pull request Dec 24, 2025
Reverts llvm#171935.

The sandbox infrastructure was (incorrectly) only implemented for `clang
-cc1` jobs created by the driver in llvm#165350. Direct
`clang -cc1` invocations had the sandbox disabled. This reduced the
coverage of our test suite and lead to sandbox violations for people
using asserts-enabled Clang.

This PR temporarily disables the sandbox for asserts builds, so that we
have time to investigate and fix sandbox violations for direct `clang
-cc1` commands and re-enable for asserts builds at a later time.
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jan 6, 2026
Reverts llvm#171935.

The sandbox infrastructure was (incorrectly) only implemented for `clang
-cc1` jobs created by the driver in llvm#165350. Direct
`clang -cc1` invocations had the sandbox disabled. This reduced the
coverage of our test suite and lead to sandbox violations for people
using asserts-enabled Clang.

This PR temporarily disables the sandbox for asserts builds, so that we
have time to investigate and fix sandbox violations for direct `clang
-cc1` commands and re-enable for asserts builds at a later time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants