Skip to content

Conversation

@makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 19, 2025

Some downstreams depend on our libraries having the uniform prefix.

@llvmbot
Copy link
Member

llvmbot commented Dec 19, 2025

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/173029.diff

1 Files Affected:

  • (modified) mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeLists.txt (+1-1)
diff --git a/mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeLists.txt b/mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeLists.txt
index e8fd9c493b975..8a25b23907f4b 100644
--- a/mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeLists.txt
+++ b/mlir/lib/Conversion/ArithAndMathToAPFloat/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_mlir_library(ArithAndMathToAPFloatUtils
+add_mlir_library(MLIRArithAndMathToAPFloatUtils
   Utils.cpp
   PARTIAL_SOURCES_INTENDED
 

@makslevental makslevental enabled auto-merge (squash) December 19, 2025 15:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also change it here and below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@github-actions
Copy link

🐧 Linux x64 Test Results

The build failed before running any tests. Detailed information about the build failure could not be automatically obtained.

Download the build's log file to see the details.

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the infrastructure label.

@github-actions
Copy link

🪟 Windows x64 Test Results

The build failed before running any tests. Detailed information about the build failure could not be automatically obtained.

Download the build's log file to see the details.

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the infrastructure label.

@joker-eph
Copy link
Collaborator

Please add a short description to the PR to provide context (title says "what", the description is a good place for the "why").

@makslevental makslevental enabled auto-merge (squash) December 19, 2025 16:10
@makslevental makslevental merged commit 35e068c into main Dec 19, 2025
8 of 9 checks passed
@makslevental makslevental deleted the users/makslevental/fixnamehelper branch December 19, 2025 16:13
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Dec 19, 2025
Some downstreams depend on our libraries having the uniform prefix.
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 19, 2025

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve2-vla running on linaro-g4-02 while building mlir at step 7 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/10622

Here is the relevant piece of the build log for the reference
Step 7 (ninja check 1) failure: stage 1 checked (failure)
******************** TEST 'SanitizerCommon-ubsan-aarch64-Linux :: Posix/create_thread_loop2.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/./bin/clang  --driver-mode=g++ -gline-tables-only -fsanitize=undefined   -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta  -funwind-tables  -I/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/compiler-rt/test -ldl -O3 -pthread /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/compiler-rt/test/sanitizer_common/TestCases/Posix/create_thread_loop2.cpp -o /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/ubsan-aarch64-Linux/Posix/Output/create_thread_loop2.cpp.tmp &&  /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/ubsan-aarch64-Linux/Posix/Output/create_thread_loop2.cpp.tmp 10
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=undefined -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -funwind-tables -I/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/compiler-rt/test -ldl -O3 -pthread /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/compiler-rt/test/sanitizer_common/TestCases/Posix/create_thread_loop2.cpp -o /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/ubsan-aarch64-Linux/Posix/Output/create_thread_loop2.cpp.tmp
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/ubsan-aarch64-Linux/Posix/Output/create_thread_loop2.cpp.tmp 10
# .---command stderr------------
# | UndefinedBehaviorSanitizer:DEADLYSIGNAL
# | ==3618887==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0xf10178dff1e8 (pc 0xf101792f1250 bp 0xf101297ae7a0 sp 0xf101297ae7a0 T3619493)
# | ==3618887==The signal is caused by a READ memory access.
# |     #0 0xf101792f1250 in pthread_detach nptl/pthread_detach.c:48:29
# |     #1 0xabe0dd48f55c in loop(void*) /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/compiler-rt/test/sanitizer_common/TestCases/Posix/create_thread_loop2.cpp:24:7
# |     #2 0xf101792f0394 in start_thread nptl/pthread_create.c:442:8
# |     #3 0xf10179359e98  misc/../sysdeps/unix/sysv/linux/aarch64/clone.S:79
# | 
# | ==3618887==Register values:
# |  x0 = 0x0000000000000000   x1 = 0x0000f10178dff0e0   x2 = 0x0000f10178dff508   x3 = 0x0000000000000008  
# |  x4 = 0x0000f10178dff1b0   x5 = 0x0000f10178dff8a0   x6 = 0x0000f10178dff1b0   x7 = 0x0000f101785f0000  
# |  x8 = 0x0000000000000087   x9 = 0xffffffffffffffe0  x10 = 0x0000f101792f00c0  x11 = 0x00000000003d0f00  
# | x12 = 0x0000f10178dff0e0  x13 = 0x0000f10179419450  x14 = 0x0000000000000140  x15 = 0x0000f10160000970  
# | x16 = 0x0000000000000001  x17 = 0x0000f101792f1220  x18 = 0x0000000000000000  x19 = 0x0000f10178dff0e0  
# | x20 = 0x0000abe0dd48f5b0  x21 = 0x0000abe0dd4b6bc0  x22 = 0x0000000000000007  x23 = 0x0000fffffd3b919f  
# | x24 = 0x0000000000000000  x25 = 0x0000f10128fa0000  x26 = 0x000000000080e920  x27 = 0x0000f10179779080  
# | x28 = 0x0000f10128fa0000   fp = 0x0000f101297ae7a0   lr = 0x0000f101792f124c   sp = 0x0000f101297ae7a0  
# | UndefinedBehaviorSanitizer can not provide additional info.
# | SUMMARY: UndefinedBehaviorSanitizer: SEGV nptl/pthread_detach.c:48:29 in pthread_detach
# | ==3618887==ABORTING
# `-----------------------------
# error: command failed with exit status: 1

--

********************


valadaptive pushed a commit to valadaptive/llvm-project that referenced this pull request Dec 24, 2025
Some downstreams depend on our libraries having the uniform prefix.
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jan 6, 2026
Some downstreams depend on our libraries having the uniform prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants