Skip to content

Conversation

@zeyi2
Copy link
Member

@zeyi2 zeyi2 commented Dec 9, 2025

Related discussion: #171058 (comment)

@llvmbot
Copy link
Member

llvmbot commented Dec 9, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: mitchell (zeyi2)

Changes

Related discussion: #171058 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/171413.diff

2 Files Affected:

  • (modified) clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst (+2)
  • (modified) clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst (+1)
diff --git a/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst b/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst
index 5ef3554fc4d95..31ee3bd457d03 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst
@@ -10,3 +10,5 @@ for more information.
 Finds usages of C-style casts.
 
 https://google.github.io/styleguide/cppguide.html#Casting
+
+Corresponding cpplint.py check name: `readability/casting`.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst b/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst
index b88a928398612..c43fb00d02d09 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst
@@ -3,6 +3,7 @@
 modernize-avoid-c-style-cast
 ============================
 
+Finds usages of C-style casts.
 
 C-style casts can perform a variety of different conversions (``const_cast``,
 ``static_cast``, ``reinterpret_cast``, or a combination). This makes them

@llvmbot
Copy link
Member

llvmbot commented Dec 9, 2025

@llvm/pr-subscribers-clang-tidy

Author: mitchell (zeyi2)

Changes

Related discussion: #171058 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/171413.diff

2 Files Affected:

  • (modified) clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst (+2)
  • (modified) clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst (+1)
diff --git a/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst b/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst
index 5ef3554fc4d95..31ee3bd457d03 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/google/readability-casting.rst
@@ -10,3 +10,5 @@ for more information.
 Finds usages of C-style casts.
 
 https://google.github.io/styleguide/cppguide.html#Casting
+
+Corresponding cpplint.py check name: `readability/casting`.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst b/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst
index b88a928398612..c43fb00d02d09 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/modernize/avoid-c-style-cast.rst
@@ -3,6 +3,7 @@
 modernize-avoid-c-style-cast
 ============================
 
+Finds usages of C-style casts.
 
 C-style casts can perform a variety of different conversions (``const_cast``,
 ``static_cast``, ``reinterpret_cast``, or a combination). This makes them

Copy link
Contributor

@vbvictor vbvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Islam-Imad
Copy link
Contributor

Related discussion: #171058 (comment)

Sorry about that 😐
but I only moved the requested lines from past review

@zeyi2 zeyi2 merged commit 6b59a95 into llvm:main Dec 9, 2025
14 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 9, 2025

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-sie-ubuntu-fast running on sie-linux-worker while building clang-tools-extra at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/41880

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Analysis/ftime-trace.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/22/include -nostdsysteminc -analyze -setup-static-analyzer -analyzer-checker=core /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp -ftime-trace=/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.raw.json -ftime-trace-granularity=0 -verify
# executed command: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/22/include -nostdsysteminc -analyze -setup-static-analyzer -analyzer-checker=core /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp -ftime-trace=/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.raw.json -ftime-trace-granularity=0 -verify
# note: command had no output on stdout or stderr
# RUN: at line 2
"/usr/bin/python3.10" -c 'import json, sys; print(json.dumps(json.load(sys.stdin), indent=4))' < /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.raw.json > /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.formatted.json
# executed command: /usr/bin/python3.10 -c 'import json, sys; print(json.dumps(json.load(sys.stdin), indent=4))'
# note: command had no output on stdout or stderr
# RUN: at line 3
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck --input-file=/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.formatted.json --check-prefix=CHECK /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp
# executed command: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck --input-file=/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.formatted.json --check-prefix=CHECK /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp
# .---command stderr------------
# | �[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp:34:11: �[0m�[0;1;31merror: �[0m�[1mCHECK: expected string not found in input
�[0m# | �[1m�[0m// CHECK: "name": "Total CheckerManager::runCheckersForStmt (Pre)",
# | �[0;1;32m          ^
�[0m# | �[0;1;32m�[0m�[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.formatted.json:2578:3: �[0m�[0;1;30mnote: �[0m�[1mscanning from here
�[0m# | �[1m�[0m }
# | �[0;1;32m  ^
�[0m# | �[0;1;32m�[0m�[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.formatted.json:2790:2: �[0m�[0;1;30mnote: �[0m�[1mpossible intended match here
�[0m# | �[1m�[0m "name": "Total CheckerManager::runCheckersForStmt (Post)",
# | �[0;1;32m ^
�[0m# | �[0;1;32m�[0m
# | Input file: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/clang/test/Analysis/Output/ftime-trace.cpp.tmp.formatted.json
# | Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# | �[1m�[0m�[0;1;30m            1: �[0m�[1m�[0;1;46m{ �[0m
# | �[0;1;30m            2: �[0m�[1m�[0;1;46m "traceEvents": [ �[0m
# | �[0;1;30m            3: �[0m�[1m�[0;1;46m { �[0m
# | �[0;1;30m            4: �[0m�[1m�[0;1;46m "pid": 1599032, �[0m
# | �[0;1;30m            5: �[0m�[1m�[0;1;46m "tid": 1599032, �[0m
# | �[0;1;30m            6: �[0m�[1m�[0;1;46m "ts": 9046, �[0m
# | �[0;1;30m            7: �[0m�[1m�[0;1;46m "ph": "X", �[0m
# | �[0;1;30m            8: �[0m�[1m�[0;1;46m "dur": 255, �[0m
# | �[0;1;30m            9: �[0m�[1m�[0;1;46m "name": "ParseDeclarationOrFunctionDefinition", �[0m
# | �[0;1;30m           10: �[0m�[1m�[0;1;46m "args": { �[0m
# | �[0;1;30m           11: �[0m�[1m�[0;1;46m "detail": "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Analysis/ftime-trace.cpp:48:1" �[0m
# | �[0;1;30m           12: �[0m�[1m�[0;1;46m } �[0m
# | �[0;1;30m           13: �[0m�[1m�[0;1;46m }, �[0m
# | �[0;1;30m           14: �[0m�[1m�[0;1;46m { �[0m
# | �[0;1;30m           15: �[0m�[1m�[0;1;46m "pid": 1599032, �[0m
# | �[0;1;30m           16: �[0m�[1m�[0;1;46m "tid": 1599032, �[0m
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants