[LLVM/CodeGen] Use the correct address space when building structor tables. #171247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables. No in-tree target exercises this, but it's needed for CHERI, and I believe its correctness is verifiable by inspection. Co-authored-by: Alex Richardson <[email protected]>
Collaborator
Author
|
@arichardson @jrtc27 for awareness |
arichardson
approved these changes
Dec 9, 2025
Member
arichardson
left a comment
arichardson
left a comment
There was a problem hiding this comment.
LGTM. Not sure if it's easy to add a test for this.
| @@ -3473,7 +3473,7 @@ void AsmPrinter::emitXXStructorList(const DataLayout &DL, const Constant *List, | |||
| if (!TM.Options.UseInitArray) | |||
| std::reverse(Structors.begin(), Structors.end()); | |||
|
|
|||
| const Align Align = DL.getPointerPrefAlignment(); | |||
| const Align Align = DL.getPointerPrefAlignment(DL.getProgramAddressSpace()); | |||
Member
There was a problem hiding this comment.
I think the only target with non-zero program address space is AVR, but not sure if it's possible to create a minimal test case there.
Collaborator
Author
There was a problem hiding this comment.
I honestly don't know enough about AVR to tell.
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…ables. (llvm#171247) No in-tree target exercises this, but it's needed for CHERI, and I believe its correctness is verifiable by inspection. Co-authored-by: Alex Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No in-tree target exercises this, but it's needed for CHERI, and I believe its correctness is verifiable by inspection.
Co-authored-by: Alex Richardson [email protected]