[NFC][AMDGPU] Remove unused TableGen generated enum #171170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This GenericEnum was just adding separate values for VOP3P_Pseudo opcodes in the same namespace as existing opcodes that did not match. They were defined in AMDGPUGenSearchableTables.inc by tablegen emitter but were guarded out by #ifdef. Because of that, they were never included in the code, so the compiler never reported the naming conflict and the bug never had a chance to surface.
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Mirko Brkušanin (mbrkusanin) ChangesThis GenericEnum was just adding separate values for VOP3P_Pseudo opcodes Full diff: https://github.com/llvm/llvm-project/pull/171170.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/VOP3PInstructions.td b/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
index 786e75f081e44..2dfa905848a34 100644
--- a/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
@@ -1364,16 +1364,10 @@ class WMMAOpcodeMapping<Instruction TwoAddr, Instruction ThreeAddr> {
field bit is_wmma_xdl;
}
-def WMMAOpcode : GenericEnum {
- let FilterClass = "VOP3P_Pseudo";
-}
-
class WMMAMappingTable : GenericTable {
let FilterClass = "WMMAOpcodeMapping";
let CppTypeName = "WMMAOpcodeMappingInfo";
let Fields = ["Opcode2Addr", "Opcode3Addr"];
- string TypeOf_Opcode2Addr = "WMMAOpcode";
- string TypeOf_Opcode3Addr = "WMMAOpcode";
}
def WMMAOpcode2AddrMappingTable : WMMAMappingTable {
|
mbrkusanin
changed the title
arsenm
approved these changes
Dec 8, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/18741 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This GenericEnum was just adding separate values for VOP3P_Pseudo opcodes
in the same namespace as existing opcodes that did not match. They were
defined in AMDGPUGenSearchableTables.inc by tablegen emitter but were
guarded out by #ifdef. Because of that, they were never included in the
code, so the compiler never reported the naming conflict and the bug never
had a chance to surface.