[NFC][libclc] Delete OpenCL builtin declarations #170803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow-up of comment llvm#168318 (comment) libclc OpenCL library is already compiled with flag `-fdeclare-opencl-builtins -finclude-default-header`.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes OpenCL builtin function declarations from the libclc library implementation files and headers. Since the library is already compiled with -fdeclare-opencl-builtins -finclude-default-header flags, these manual declarations are redundant and can be eliminated. The changes streamline the codebase by replacing explicit builtin declarations with the opencl-base.h include where necessary.
- Removes redundant OpenCL builtin declaration header includes from implementation files
- Deletes header files containing manual function declarations that are now provided automatically
- Replaces removed includes with
opencl-base.hin files that still need OpenCL base definitions
Reviewed changes
Copilot reviewed 300 out of 476 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libclc/opencl/lib/generic/geometric/*.cl | Removed redundant geometric function declaration includes |
| libclc/opencl/lib/generic/common/*.cl | Removed redundant common function declaration includes |
| libclc/opencl/lib/generic/atomic/*.cl | Removed redundant atomic function declaration includes |
| libclc/opencl/lib/generic/async/*.cl | Removed redundant async function declarations, replaced with opencl-base.h |
| libclc/opencl/lib/clspv/shared/vstore_half.cl | Consolidated multiple declaration includes into opencl-base.h |
| libclc/opencl/lib/clspv/math/fma.cl | Removed redundant fma declaration include |
| libclc/opencl/lib/amdgcn/workitem/*.cl | Removed redundant workitem function declarations, some replaced with opencl-base.h |
| libclc/opencl/lib/amdgcn/synchronization/barrier.cl | Removed redundant barrier declaration include |
| libclc/opencl/lib/amdgcn/mem_fence/fence.cl | Removed redundant explicit fence declaration include |
| libclc/opencl/lib/amdgcn-amdhsa/workitem/*.cl | Removed redundant workitem declarations, replaced with opencl-base.h |
| libclc/opencl/include/clc/opencl/**/*.h | Deleted entire header files containing now-redundant OpenCL builtin declarations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arsenm
approved these changes
Dec 8, 2025
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
This is follow-up of comment llvm#168318 (comment) libclc OpenCL library is already compiled with flag `-fdeclare-opencl-builtins -finclude-default-header`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up of comment
#168318 (comment)
libclc OpenCL library is already compiled with flag
-fdeclare-opencl-builtins -finclude-default-header.