[compiler-rt] [test] Generalize an UNSUPPORTED marking#168858
Merged
[compiler-rt] [test] Generalize an UNSUPPORTED marking#168858
Conversation
Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.
Member
Author
|
CC @padriff |
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Martin Storsjö (mstorsjo) ChangesDon't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either. Full diff: https://github.com/llvm/llvm-project/pull/168858.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
index 07c143609e94d..cb771f5c95639 100644
--- a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
+++ b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
@@ -1,6 +1,6 @@
// Test to demonstrate compile-time disabling of container-overflow checks
// in order to handle uninstrumented libraries
-// UNSUPPORTED: target={{.*windows-msvc.*}}
+// UNSUPPORTED: target={{.*windows-.*}}
// Mimic a closed-source library compiled without ASan
// RUN: %clangxx_asan -fno-sanitize=address -DSHARED_LIB %s %fPIC -shared -o %t-so.so
|
🐧 Linux x64 Test Results
|
vitalybuka
approved these changes
Nov 20, 2025
Contributor
|
These have now been marked unsupported for all platforms here: https://github.com/llvm/llvm-project/pull/168821/files. |
Member
Author
Thanks! But as long as the test is still in place, I'll go ahead and merge this, so the issue doesn't reappear if the |
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't specifically target windows-msvc - the same goes for any windows target; mingw doesn't have dlfcn.h either.