Merged
Conversation
llvmbot
added
compiler-rt
compiler-rt:asan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Paddy McDonald (padriff) ChangesNew test stack_container_dynamic_lib.cpp has errors under gcc. Require clang while better fix is investigated Full diff: https://github.com/llvm/llvm-project/pull/168792.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
index e17c537f4ac1c..1321796759189 100644
--- a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
+++ b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
@@ -2,6 +2,9 @@
// in order to handle uninstrumented libraries
// UNSUPPORTED: target={{.*windows-msvc.*}}
+// FIXME: Fix this test under GCC.
+// REQUIRES: Clang
+
// Mimic a closed-source library compiled without ASan
// RUN: %clangxx_asan -fno-sanitize=address -DSHARED_LIB %s %fPIC -shared -o %t-so.so
|
Contributor
Author
|
@dyung - disabling the test under gcc for now to allow me to see if I can figure out how to get it working in that environment. If this looks OK, can you please merge |
🐧 Linux x64 Test Results
|
vitalybuka
approved these changes
Nov 20, 2025
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
New test stack_container_dynamic_lib.cpp has errors under gcc. Require clang while better fix is investigated
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
New test stack_container_dynamic_lib.cpp has errors under gcc. Require clang while better fix is investigated
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
New test stack_container_dynamic_lib.cpp has errors under gcc. Require clang while better fix is investigated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New test stack_container_dynamic_lib.cpp has errors under gcc.
Require clang while better fix is investigated