[CI] Fix misspelled runtimes_targets variable#167696
[CI] Fix misspelled runtimes_targets variable#167696boomanaiden154 merged 3 commits intollvm:mainfrom
Conversation
This was preventing check-compiler-rt from actually running when we touched a project that was supposed to cause compiler-rt to be tested.
|
@llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesThis was preventing check-compiler-rt from actually running when we touched a project that was supposed to cause compiler-rt to be tested. Full diff: https://github.com/llvm/llvm-project/pull/167696.diff 1 Files Affected:
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index beaed71f49f65..7b926b87f3623 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -55,7 +55,7 @@ start-group "ninja"
ninja -C "${BUILD_DIR}" -k 0 ${targets} |& tee ninja.log
cp ${BUILD_DIR}/.ninja_log ninja.ninja_log
-if [[ "${runtime_targets}" != "" ]]; then
+if [[ "${runtimes_targets}" != "" ]]; then
start-group "ninja runtimes"
ninja -C "${BUILD_DIR}" -k 0 ${runtimes_targets} |& tee ninja_runtimes.log
|
zmodem
left a comment
There was a problem hiding this comment.
lgtm, thanks!
Let's see what the bot says; there may be issues since it hasn't run these before.
Ah, yep. Looks like test failures because the newer version of VS in the premerge CI marks some libc functions as deprecated in favor of the annex k versions... Should be a simple fix. It seems like the |
This was preventing check-compiler-rt from actually running when we touched a project that was supposed to cause compiler-rt to be tested.