[MLIR][NFC] Fix minor spelling issues#167606
Merged
ashermancinelli merged 1 commit intollvm:mainfrom Nov 12, 2025
Merged
Conversation
Member
|
@llvm/pr-subscribers-mlir Author: Asher Mancinelli (ashermancinelli) ChangesFixes minor spelling issues in the shape dialect's passes tablegen file. Full diff: https://github.com/llvm/llvm-project/pull/167606.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td b/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td
index 588b5ebc5e37a..0b8c465fdcbbe 100644
--- a/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td
@@ -16,7 +16,7 @@ def OutlineShapeComputationPass
let summary = "Using shape.func to preserve shape computation";
let description = [{
This pass outlines the shape computation part in high level IR by adding
- shape.func and populate corresponding mapping infoemation into
+ shape.func and populate corresponding mapping information into
ShapeMappingAnalysis. The shape computation part is usually introduced by
shape reification, and each single dynamic shape is denoted by shape.with_shape.
@@ -80,12 +80,12 @@ def OutlineShapeComputationPass
For the above example, the shape computation is inlined in the input IR,
which is used for two values' (test.abs and test.concat) shape. And the shape
- compuatation part is outlined in the output IR.
+ computation part is outlined in the output IR.
- And the shape mapping infomation will be:
+ And the shape mapping information will be:
```
- // ---- Shape Mapping Infomation -----
+ // ---- Shape Mapping Information -----
// - Shape for: %0 = "test.abs"(%arg0) : (tensor<?x4x?xf32>) -> tensor<?x4x?xf32> :: @shape_cal_0(<block argument> of type 'tensor<?x4x?xf32>' at index: 0)
// - Shape for: %1 = "test.concat"(%0, %arg1) {axis = 0 : i64} : (tensor<?x4x?xf32>, tensor<2x4x?xf32>) -> tensor<?x4x?xf32> :: @shape_cal_1(<block argument> of type 'tensor<?x4x?xf32>' at index: 0)
```
|
Member
|
@llvm/pr-subscribers-mlir-shape Author: Asher Mancinelli (ashermancinelli) ChangesFixes minor spelling issues in the shape dialect's passes tablegen file. Full diff: https://github.com/llvm/llvm-project/pull/167606.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td b/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td
index 588b5ebc5e37a..0b8c465fdcbbe 100644
--- a/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/Shape/Transforms/Passes.td
@@ -16,7 +16,7 @@ def OutlineShapeComputationPass
let summary = "Using shape.func to preserve shape computation";
let description = [{
This pass outlines the shape computation part in high level IR by adding
- shape.func and populate corresponding mapping infoemation into
+ shape.func and populate corresponding mapping information into
ShapeMappingAnalysis. The shape computation part is usually introduced by
shape reification, and each single dynamic shape is denoted by shape.with_shape.
@@ -80,12 +80,12 @@ def OutlineShapeComputationPass
For the above example, the shape computation is inlined in the input IR,
which is used for two values' (test.abs and test.concat) shape. And the shape
- compuatation part is outlined in the output IR.
+ computation part is outlined in the output IR.
- And the shape mapping infomation will be:
+ And the shape mapping information will be:
```
- // ---- Shape Mapping Infomation -----
+ // ---- Shape Mapping Information -----
// - Shape for: %0 = "test.abs"(%arg0) : (tensor<?x4x?xf32>) -> tensor<?x4x?xf32> :: @shape_cal_0(<block argument> of type 'tensor<?x4x?xf32>' at index: 0)
// - Shape for: %1 = "test.concat"(%0, %arg1) {axis = 0 : i64} : (tensor<?x4x?xf32>, tensor<2x4x?xf32>) -> tensor<?x4x?xf32> :: @shape_cal_1(<block argument> of type 'tensor<?x4x?xf32>' at index: 0)
```
|
git-crd
pushed a commit
to git-crd/crd-llvm-project
that referenced
this pull request
Nov 13, 2025
Fixes minor spelling issues in the shape dialect's passes tablegen file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes minor spelling issues in the shape dialect's passes tablegen file.