[ProfCheck] Mark Some profverify Tests as Unsupported#167544
Merged
boomanaiden154 merged 1 commit intollvm:mainfrom Nov 11, 2025
Merged
[ProfCheck] Mark Some profverify Tests as Unsupported#167544boomanaiden154 merged 1 commit intollvm:mainfrom
boomanaiden154 merged 1 commit intollvm:mainfrom
Conversation
These tests fail in the profcheck configuration because profinject gets added to the pipeline and adds metadata that changes the input PGO information.
Member
|
@llvm/pr-subscribers-pgo @llvm/pr-subscribers-llvm-transforms Author: Aiden Grossman (boomanaiden154) ChangesThese tests fail in the profcheck configuration because profinject gets added to the pipeline and adds metadata that changes the input PGO information. Full diff: https://github.com/llvm/llvm-project/pull/167544.diff 5 Files Affected:
diff --git a/llvm/test/Transforms/PGOProfile/prof-verify-no-entrycount.ll b/llvm/test/Transforms/PGOProfile/prof-verify-no-entrycount.ll
index 3b059fd7d8800..9c5f046af47af 100644
--- a/llvm/test/Transforms/PGOProfile/prof-verify-no-entrycount.ll
+++ b/llvm/test/Transforms/PGOProfile/prof-verify-no-entrycount.ll
@@ -1,3 +1,7 @@
+; This test fails under the profcheck configuration due to profcheck creating
+; metadata.
+; UNSUPPORTED: profcheck
+
; Test prof-verify for functions without entry count
; RUN: not opt -passes=prof-verify %s -o - 2>&1 | FileCheck %s
diff --git a/llvm/test/Transforms/PGOProfile/prof-verify.ll b/llvm/test/Transforms/PGOProfile/prof-verify.ll
index 50159506e8313..75d1e6a3db571 100644
--- a/llvm/test/Transforms/PGOProfile/prof-verify.ll
+++ b/llvm/test/Transforms/PGOProfile/prof-verify.ll
@@ -1,3 +1,7 @@
+; This test fails under the profcheck configuration due to profcheck creating
+; metadata.
+; UNSUPPORTED: profcheck
+
; Test prof-inject and prof-verify
; RUN: opt -passes=prof-inject %s -S -o - | FileCheck %s --check-prefix=INJECT
diff --git a/llvm/test/Transforms/PGOProfile/profcheck-select.ll b/llvm/test/Transforms/PGOProfile/profcheck-select.ll
index b5dc97d2d5a6d..74bcb3f52428b 100644
--- a/llvm/test/Transforms/PGOProfile/profcheck-select.ll
+++ b/llvm/test/Transforms/PGOProfile/profcheck-select.ll
@@ -1,3 +1,7 @@
+; This test fails under the profcheck configuration due to profcheck creating
+; metadata.
+; UNSUPPORTED: profcheck
+
; RUN: split-file %s %t
; RUN: opt -passes=prof-inject %t/inject.ll -S -o - | FileCheck %t/inject.ll
diff --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index 725ddb877f9ec..94cf8bc358514 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -69,6 +69,8 @@
# profiling doesn't work quite well on GPU, excluding
config.excludes.append("AMDGPU")
+ config.available_features.add("profcheck")
+
# test_source_root: The root path where tests are located.
config.test_source_root = os.path.dirname(__file__)
diff --git a/llvm/utils/profcheck-xfail.txt b/llvm/utils/profcheck-xfail.txt
index b1f20a73c3b2b..15f2c79784d1e 100644
--- a/llvm/utils/profcheck-xfail.txt
+++ b/llvm/utils/profcheck-xfail.txt
@@ -614,9 +614,6 @@ Transforms/PGOProfile/chr-lifetimes.ll
Transforms/PGOProfile/chr-poison.ll
Transforms/PGOProfile/comdat.ll
Transforms/PGOProfile/memop_profile_funclet_wasm.ll
-Transforms/PGOProfile/profcheck-select.ll
-Transforms/PGOProfile/prof-verify.ll
-Transforms/PGOProfile/prof-verify-no-entrycount.ll
Transforms/PGOProfile/X86/macho.ll
Transforms/PhaseOrdering/AArch64/constraint-elimination-placement.ll
Transforms/PhaseOrdering/AArch64/globals-aa-required-for-vectorization.ll
|
alanzhao1
approved these changes
Nov 11, 2025
mtrofin
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests fail in the profcheck configuration because profinject gets added to the pipeline and adds metadata that changes the input PGO information.