Reapply "[mlir] Add FP software implementation lowering pass: arith-to-apfloat (#166618)"#167431
Merged
makslevental merged 2 commits intomainfrom Nov 11, 2025
Merged
Conversation
Member
|
@llvm/pr-subscribers-mlir-func @llvm/pr-subscribers-mlir Author: Maksim Levental (makslevental) ChangesReland with MLIRFuncUtils linked in. Full diff: https://github.com/llvm/llvm-project/pull/167431.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt b/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt
index b0d1e46b3655f..b5ec49c087163 100644
--- a/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt
+++ b/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt
@@ -14,4 +14,5 @@ add_mlir_conversion_library(MLIRArithToAPFloat
MLIRArithDialect
MLIRArithTransforms
MLIRFuncDialect
+ MLIRFuncUtils
)
|
aa896fd to
cc718f5
Compare
matthias-springer
approved these changes
Nov 11, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/20794 Here is the relevant piece of the build log for the reference |
makslevental
added a commit
that referenced
this pull request
Nov 11, 2025
makslevental
added a commit
that referenced
this pull request
Nov 11, 2025
makslevental
added a commit
that referenced
this pull request
Nov 11, 2025
makslevental
added a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #166618 with MLIRFuncUtils linked in.