REAPPLY [ORC] Add automatic shared library resolver for unresolved symbols. #148410 #164551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/16065 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/29690 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/14947 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/10474 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/27157 Here is the relevant piece of the build log for the reference |
|
Hello @SahilPatidar I see the following with this patch: |
|
I’ll resolve this one. I’m waiting for the other bot failures; if the issues from other bots are not trivial, we’ll revert the PR. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/27297 Here is the relevant piece of the build log for the reference |
SahilPatidar
added a commit
to SahilPatidar/llvm-project
that referenced
this pull request
Oct 24, 2025
ronlieb
added a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 24, 2025
…olved symbols. llvm#148410 (llvm#164551)" This reverts commit 4f53413.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13287 Here is the relevant piece of the build log for the reference |
|
I need to revert the PR. The path difference issue related to the build bot is still unresolved. |
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 25, 2025
…r for unresolved symbols. #148410" (#165069) Reverting llvm/llvm-project#164551 due to persistent build bot failure caused by a path difference issue.
|
Could anyone provide some insight into this path difference issue? |
This is my bot. To avoid putting too much wear on the built-in SSD, I use symlinks in the file system to give the appearance of everything being on the same drive/path, but put the build directories either on an external SSD (this specific example), or on a RAM disk (other Mac bots). I achieve this by using symlinks. Here is some output that might be useful: Essentially the buildbot directory is at ~/buildbot-worker which is symlinked to /Volumes/ExternalSSD/buildbot-root. Within that location though, the actual sources are symlinked back to a directory on the builtin SSD located at /Users/buildbot/buildbot-root2/aarch64-darwin/llvm-project (this is mainly read-only so I'm not so worried about SSD wear), while the build directory is contained on the external SSD. Hope this helps and let me know if you have any questions. |
|
Thank you for the insight. I think I get the issue — I need to use the real path on both sides. I did that for the input libs but forgot for the directory, which caused the failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reapplies the changes previously introduced in #148410.
It introduces a redesigned and rebuilt Cling-based auto-loading workaround that enables scanning libraries and resolving unresolved symbols within those libraries.