Skip to content

[X86] Check MinMax has NaN and replace with NewX for minimumnum/maximumnum #164546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

[X86] Check MinMax has NaN and replace with NewX for minimumnum/maximumnum #164546

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28163f
[X86] Swap NewX and NewY for ordered elements for minimumnum/maximumnum
phoebewang Oct 22, 2025
813c7e2
Simplify: DAG.isKnownNeverNaN(NewX) is always false
phoebewang Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions llvm/lib/Target/X86/X86ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29507,11 +29507,14 @@ static SDValue LowerFMINIMUM_FMAXIMUM(SDValue Op, const X86Subtarget &Subtarget,
if (IgnoreNaN || DAG.isKnownNeverNaN(IsNum ? NewY : NewX))
return MinMax;

if (DAG.isKnownNeverNaN(NewX))
if (IsNum)
NewY = MinMax;
else if (DAG.isKnownNeverNaN(NewX))
NewX = NewY;
else
NewY = NewX;

SDValue IsNaN =
DAG.getSetCC(DL, SetCCType, NewX, NewX, IsNum ? ISD::SETO : ISD::SETUO);
SDValue IsNaN = DAG.getSetCC(DL, SetCCType, NewY, NewY, ISD::SETUO);

return DAG.getSelect(DL, VT, IsNaN, NewX, MinMax);
}
Expand Down
Loading