[llvm][utils] Improve the StringRef summary provider #162298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check the length of data before casting as `char[N]` because the will cause lldb to allocate `N` bytes of memory.
kastiglione
approved these changes
Oct 22, 2025
Contributor
kastiglione
left a comment
kastiglione
left a comment
There was a problem hiding this comment.
Seems reasonable, however I don't know how a StringRef could have an uninitialized length.
Co-authored-by: Dave Lee <[email protected]>
|
✅ With the latest revision this PR passed the Python code formatter. |
Refactor string summary length limit retrieval.
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
- check the length of data before casting as `char[N]` because the will cause lldb to allocate `N` bytes of memory. --------- Co-authored-by: Dave Lee <[email protected]>
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
- check the length of data before casting as `char[N]` because the will cause lldb to allocate `N` bytes of memory. --------- Co-authored-by: Dave Lee <[email protected]>
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
- check the length of data before casting as `char[N]` because the will cause lldb to allocate `N` bytes of memory. --------- Co-authored-by: Dave Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
char[N]because the will cause lldb to allocateNbytes of memory.