[TTI] Remove getVPMemoryOpCost. NFC#160838
Merged
Conversation
No target implements this and nothing calls it. The cost of vp.load/store/gather/scatter etc. are handled by BasicTTIImpl::getIntrinsicInstrCost which forwards it onto the appropriate TTI::getMemoryOpCost/getGatherScatterOpCost etc.
llvmbot
added
the
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis Author: Luke Lau (lukel97) ChangesNo target implements this and nothing calls it. The cost of vp.load/store/gather/scatter etc. are handled by BasicTTIImpl::getIntrinsicInstrCost which forwards it onto the appropriate TTI::getMemoryOpCost/getGatherScatterOpCost etc. Full diff: https://github.com/llvm/llvm-project/pull/160838.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Analysis/TargetTransformInfo.h b/llvm/include/llvm/Analysis/TargetTransformInfo.h
index 7a4abe9ee5082..5d3b233ed6b6a 100644
--- a/llvm/include/llvm/Analysis/TargetTransformInfo.h
+++ b/llvm/include/llvm/Analysis/TargetTransformInfo.h
@@ -1551,12 +1551,6 @@ class TargetTransformInfo {
OperandValueInfo OpdInfo = {OK_AnyValue, OP_None},
const Instruction *I = nullptr) const;
- /// \return The cost of VP Load and Store instructions.
- LLVM_ABI InstructionCost getVPMemoryOpCost(
- unsigned Opcode, Type *Src, Align Alignment, unsigned AddressSpace,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput,
- const Instruction *I = nullptr) const;
-
/// \return The cost of masked Load and Store instructions.
LLVM_ABI InstructionCost getMaskedMemoryOpCost(
unsigned Opcode, Type *Src, Align Alignment, unsigned AddressSpace,
diff --git a/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h b/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
index 566e1cf51631a..4cd607c0d0c8d 100644
--- a/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
+++ b/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
@@ -841,14 +841,6 @@ class TargetTransformInfoImplBase {
return 1;
}
- virtual InstructionCost getVPMemoryOpCost(unsigned Opcode, Type *Src,
- Align Alignment,
- unsigned AddressSpace,
- TTI::TargetCostKind CostKind,
- const Instruction *I) const {
- return 1;
- }
-
virtual InstructionCost
getMaskedMemoryOpCost(unsigned Opcode, Type *Src, Align Alignment,
unsigned AddressSpace,
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/12933 Here is the relevant piece of the build log for the reference |
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 6, 2025
No target implements this and nothing calls it. The cost of vp.load/store/gather/scatter etc. are handled by BasicTTIImpl::getIntrinsicInstrCost which forwards it onto the appropriate TTI::getMemoryOpCost/getGatherScatterOpCost etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No target implements this and nothing calls it. The cost of vp.load/store/gather/scatter etc. are handled by BasicTTIImpl::getIntrinsicInstrCost which forwards it onto the appropriate TTI::getMemoryOpCost/getGatherScatterOpCost etc.