Repository navigation
[CAS] Fix AIX build - #159647
[CAS] Fix AIX build#159647
Conversation
Created using spr 1.3.6
|
Sorry for the delayed update - this patch works (thanks!) but it might not be needed. The AIX bot is actually fine with the previous fix for the unused variable (https://lab.llvm.org/buildbot/#/builders/64/builds/5841), so I suspect I might be running into local environment related issues but will report back. I can close this PR if it's not necessary. Thanks again for helping with this and I apologize for the inconvenience! |
|
I believe this patch is not needed, so I will close this PR for now. Thank you again for your assistance in this issue! Greatly appreciate it! |
|
Hi @cachemeifyoucan, hope you don't mind me reopening this PR as this does fix the AIX build this time around. Would you be able to rebase this PR? |
|
@amy-kwan Sure. Rebased. Are you able to reproduce the error I mentioned in the other PR and able to check this PR fixes the problem? |
daltenty
left a comment
There was a problem hiding this comment.
Change LGTM, flock requires libbsd on AIX:
https://www.ibm.com/docs/en/aix/7.1.0?topic=l-lockfx-lockf-flock-lockf64-subroutine
Thanks!
amy-kwan
left a comment
There was a problem hiding this comment.
Thanks @cachemeifyoucan!
Confirmed that this patch resolves the AIX build, so LGTM.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/15468 Here is the relevant piece of the build log for the reference |
Fix AIX build by linking
libbsd.ato include implementation forflock.