Skip to content

[mlir][llvm] Pretty printing for trap intrinsics #159385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

[mlir][llvm] Pretty printing for trap intrinsics #159385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,16 +1162,22 @@ def LLVM_Annotation
// Trap intrinsics.
//

def LLVM_Trap : LLVM_ZeroResultIntrOp<"trap">;
def LLVM_Trap : LLVM_ZeroResultIntrOp<"trap"> {
let assemblyFormat = "attr-dict";
}

def LLVM_DebugTrap : LLVM_ZeroResultIntrOp<"debugtrap">;
def LLVM_DebugTrap : LLVM_ZeroResultIntrOp<"debugtrap"> {
let assemblyFormat = "attr-dict";
}

def LLVM_UBSanTrap : LLVM_ZeroResultIntrOp<"ubsantrap",
/*overloadedOperands=*/[], /*traits=*/[],
/*requiresAccessGroup=*/0, /*requiresAliasAnalysis=*/0,
/*requiresArgAndResultAttrs=*/0, /*requiresOpBundles=*/0,
/*immArgPositions=*/[0], /*immArgAttrNames=*/["failureKind"]> {
let arguments = (ins I8Attr:$failureKind);

let assemblyFormat = "attr-dict";
Copy link
Collaborator

@joker-eph joker-eph Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a prop-dict when there are are non-SSA value arguments.

}

/// Create a call to vscale intrinsic.
Expand Down
7 changes: 3 additions & 4 deletions mlir/test/Target/LLVMIR/Import/intrinsic.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,12 +567,11 @@ define void @annotate_intrinsics(ptr %var, ptr %ptr, i16 %int, ptr %annotation,

; CHECK-LABEL: llvm.func @trap_intrinsics
define void @trap_intrinsics() {
; CHECK: "llvm.intr.trap"() : () -> ()
; CHECK: llvm.intr.trap
call void @llvm.trap()
; CHECK: "llvm.intr.debugtrap"() : () -> ()
; CHECK: llvm.intr.debugtrap
call void @llvm.debugtrap()
; CHECK: "llvm.intr.ubsantrap"()
; CHECK-SAME: failureKind = 1
; CHECK: llvm.intr.ubsantrap {failureKind = 1 : i8}
call void @llvm.ubsantrap(i8 1)
ret void
}
Expand Down
7 changes: 7 additions & 0 deletions mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,13 @@ llvm.func @trap_intrinsics() {
"llvm.intr.debugtrap"() : () -> ()
// CHECK: call void @llvm.ubsantrap(i8 1)
"llvm.intr.ubsantrap"() {failureKind = 1 : i8} : () -> ()

// CHECK: call void @llvm.trap()
llvm.intr.trap
// CHECK: call void @llvm.debugtrap()
llvm.intr.debugtrap
// CHECK: call void @llvm.ubsantrap(i8 1)
llvm.intr.ubsantrap {failureKind = 1 : i8}
llvm.return
}

Expand Down