[llvm-debuginfo-analyzer][lit] Fix tests failing when X86 isn't available - #155678
Merged
Conversation
…able Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Member
|
@llvm/pr-subscribers-debuginfo Author: Nick Sarnie (sarnex) ChangesNeed to require the target. Fixes: #153318 Full diff: https://github.com/llvm/llvm-project/pull/155678.diff 2 Files Affected:
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s
index 58d7b28b8d65e..daeda00f55644 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s
@@ -16,6 +16,8 @@
# 12 return (int)my_var;
# 13 }
+# REQUIRES: x86-registered-target
+
# RUN: llvm-mc %s -triple=i686-pc-linux -filetype=obj -o - | \
# RUN: llvm-debuginfo-analyzer --attribute=all \
# RUN: --print=all \
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s
index efba25c46ae67..a9a90163667f6 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s
@@ -12,6 +12,8 @@
# 8 }
# 9
+# REQUIRES: x86-registered-target
+
# RUN: llvm-mc %s -triple=i686-pc-linux -filetype=obj -o - | \
# RUN: llvm-debuginfo-analyzer --attribute=all \
# RUN: --print=all \
|
adam-yang
approved these changes
Aug 27, 2025
adam-yang
left a comment
adam-yang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fix!!
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to require the target.
Fixes: #153318