[NFC][DirectX] Fix build failure

[jurahul]

Add BinaryFormat to LINK_COMPONENTS to fix the following linker error:

ld.lld: error: undefined symbol: llvm::dxbc::getRootParameterTypes()
>>> referenced by DXILRootSignature.cpp
>>>               lib/Target/DirectX/CMakeFiles/LLVMDirectXCodeGen.dir/DXILRootSignature.cpp.o:(llvm::dxil::RootSignatureAnalysisPrinter::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&))

ld.lld: error: undefined symbol: llvm::dxbc::getShaderVisibility()
>>> referenced by DXILRootSignature.cpp
>>>               lib/Target/DirectX/CMakeFiles/LLVMDirectXCodeGen.dir/DXILRootSignature.cpp.o:(llvm::dxil::RootSignatureAnalysisPrinter::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&))
>>> referenced by DXILRootSignature.cpp
>>>               lib/Target/DirectX/CMakeFiles/LLVMDirectXCodeGen.dir/DXILRootSignature.cpp.o:(llvm::dxil::RootSignatureAnalysisPrinter::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&))

Root cause: #154249 changed a header-only dependency to a real dependency without noticing that the dependency was missing in CMakeLists.txt

[jurahul]

Linux CI is the ongoing LLDB test failures and unrelated to this change

[jurahul]

I suspect the failure is specific to building with shared libs

[llvmbot]

@llvm/pr-subscribers-backend-directx

Author: Rahul Joshi (jurahul)

Changes

Add BinaryFormat to LINK_COMPONENTS to fix linker error finding symbols llvm::dxbc::getRootParameterTypes and
llvm::dxbc::getShaderVisibility

---

Full diff: https://github.com/llvm/llvm-project/pull/155441.diff

1 Files Affected:

• (modified) llvm/lib/Target/DirectX/CMakeLists.txt (+1)

diff --git a/llvm/lib/Target/DirectX/CMakeLists.txt b/llvm/lib/Target/DirectX/CMakeLists.txt
index 8100f941c8d94..6c079517e22d6 100644
--- a/llvm/lib/Target/DirectX/CMakeLists.txt
+++ b/llvm/lib/Target/DirectX/CMakeLists.txt
@@ -41,6 +41,7 @@ add_llvm_target(DirectXCodeGen
   LINK_COMPONENTS
   Analysis
   AsmPrinter
+  BinaryFormat
   CodeGen
   CodeGenTypes
   Core

[inbelic]

Thanks for catching this. Maybe you could update the commit message to include where it was found and the reason:

The DirectX backend incorrectly did not specify it's dependency on BinaryFormat as it was a header only dependency and so it did not cause any build failures.

[jurahul]

Thanks, updated the commit message with the failure seen and the root cause (that @bogner mentioned in #154249).