[libc] Fix bazel build by build by adding missing deps. #151090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
requested review from
aaronmondal,
keith and
rupprecht
as code owners
Member
|
@llvm/pr-subscribers-libc Author: Ingo Müller (ingomueller-net) ChangesThis was broken by #150661, which added an include to Full diff: https://github.com/llvm/llvm-project/pull/151090.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 0e40d92cb5c97..d9e0110c437a6 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -6379,6 +6379,7 @@ libc_function(
":__support_common",
":__support_macros_null_check",
":types_wchar_t",
+ ":wchar_utils",
],
)
|
This was broken by llvm#150661, which added includes to `wcspbrk.cpp` and `wcschr.cpp` that weren't in the dependencies of the corresponding targets. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
fix-wcspbrk-bazel-deps
branch
from
ed56941 to
edbe9de
Compare
ingomueller-net
changed the title
:wchar_utils to deps.
lntue
approved these changes
Jul 29, 2025
ingomueller-net
added a commit
that referenced
this pull request
Jul 29, 2025
This adds two dependencies that I wanted to be part of #151090 but forgot to add them before the last push, which related to `wcschr.cpp` and were originally broken by #150661. Signed-off-by: Ingo Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #150661, which added includes to
wcspbrk.cppandwcschr.cppthat weren't in the dependencies of the corresponding targets.