Skip to content

[clang][analyzer] Delay checking the model-path #150133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
+13 −6
Merged

[clang][analyzer] Delay checking the model-path #150133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions clang/lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,11 +1323,6 @@ static void parseAnalyzerConfigs(AnalyzerOptions &AnOpts,
if (!AnOpts.CTUDir.empty() && !llvm::sys::fs::is_directory(AnOpts.CTUDir))
Diags->Report(diag::err_analyzer_config_invalid_input) << "ctu-dir"
<< "a filename";

if (!AnOpts.ModelPath.empty() &&
!llvm::sys::fs::is_directory(AnOpts.ModelPath))
Diags->Report(diag::err_analyzer_config_invalid_input) << "model-path"
<< "a filename";
}

/// Generate a remark argument. This is an inverse of `ParseOptimizationRemark`.
Expand Down
11 changes: 10 additions & 1 deletion clang/lib/StaticAnalyzer/Frontend/ModelInjector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "ModelInjector.h"
#include "clang/AST/Decl.h"
#include "clang/AST/DeclObjC.h"
#include "clang/Basic/DiagnosticDriver.h"
#include "clang/Basic/LangStandard.h"
#include "clang/Basic/Stack.h"
#include "clang/Frontend/ASTUnit.h"
Expand All @@ -24,7 +25,15 @@
using namespace clang;
using namespace ento;

ModelInjector::ModelInjector(CompilerInstance &CI) : CI(CI) {}
ModelInjector::ModelInjector(CompilerInstance &CI) : CI(CI) {
if (CI.getAnalyzerOpts().ShouldEmitErrorsOnInvalidConfigValue &&
!CI.getAnalyzerOpts().ModelPath.empty()) {
auto S = CI.getVirtualFileSystem().status(CI.getAnalyzerOpts().ModelPath);
if (!S || S->getType() != llvm::sys::fs::file_type::directory_file)
CI.getDiagnostics().Report(diag::err_analyzer_config_invalid_input)
<< "model-path" << "a filename";
}
}

Stmt *ModelInjector::getBody(const FunctionDecl *D) {
onBodySynthesis(D);
Expand Down
3 changes: 3 additions & 0 deletions clang/test/Analysis/model-file-missing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// RUN: not %clang_analyze_cc1 -analyzer-checker=core -analyzer-config model-path=%t/blah %s -o - 2>&1 | FileCheck %s
// CHECK: error: invalid input for analyzer-config option 'model-path', that expects a filename value
// CHECK-NEXT: 1 error generated
Loading