[CI] Update Best Practices on Job Events for Stacked PRs #149734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have seen a couple recent issues around workflows getting triggered on events that are not correctly configured to handle stacked PRs. This potentially resulted in workflows getting run twice (if they were also triggering on push events) or to not run at all (if there were branch restrictions for the pull_request event). Add some documentation to the best practices page so we can hopefully avoid these issues in the future and have some documentation to refer to during code review.
cmtice
approved these changes
Jul 21, 2025
This was referenced Jul 23, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
I have seen a couple recent issues around workflows getting triggered on events that are not correctly configured to handle stacked PRs. This potentially resulted in workflows getting run twice (if they were also triggering on push events) or to not run at all (if there were branch restrictions for the pull_request event). Add some documentation to the best practices page so we can hopefully avoid these issues in the future and have some documentation to refer to during code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen a couple recent issues around workflows getting triggered on events that are not correctly configured to handle stacked PRs. This potentially resulted in workflows getting run twice (if they were also triggering on push events) or to not run at all (if there were branch restrictions for the pull_request event). Add some documentation to the best practices page so we can hopefully avoid these issues in the future and have some documentation to refer to during code review.