Skip to content

[flang] Fixed a crash with undeclared variable in implicit-do loop #149513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2025
Merged

[flang] Fixed a crash with undeclared variable in implicit-do loop #149513

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a155a35
[flang] Control alignment of constant folded reals
eugeneepshteyn Jul 17, 2025
43102f9
Added comment
eugeneepshteyn Jul 17, 2025
5df6817
Merge branch 'llvm:main' into fold-real-align
eugeneepshteyn Jul 17, 2025
26432b5
Comment update
eugeneepshteyn Jul 17, 2025
270cdfc
[flang]
eugeneepshteyn Jul 18, 2025
fc450bc
Actual fix
eugeneepshteyn Jul 18, 2025
95dd942
Added test
eugeneepshteyn Jul 18, 2025
38133c4
Restored the files accidentally grabbed from another branch
eugeneepshteyn Jul 18, 2025
8a0cac8
Undo unnecessary change
eugeneepshteyn Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flang/lib/Semantics/check-do-forall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,9 @@ void DoForallChecker::Leave(const parser::IoControlSpec &ioControlSpec) {
void DoForallChecker::Leave(const parser::OutputImpliedDo &outputImpliedDo) {
const auto &control{std::get<parser::IoImpliedDoControl>(outputImpliedDo.t)};
const parser::Name &name{control.name.thing.thing};
context_.CheckIndexVarRedefine(name.source, *name.symbol);
if (name.symbol) {
context_.CheckIndexVarRedefine(name.source, *name.symbol);
}
}

void DoForallChecker::Leave(const parser::StatVariable &statVariable) {
Expand Down
2 changes: 1 addition & 1 deletion flang/lib/Semantics/resolve-names.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8700,7 +8700,7 @@ const parser::Name *DeclarationVisitor::ResolveName(const parser::Name &name) {
return &name;
}
if (isImplicitNoneType() && !deferImplicitTyping_) {
Say(name, "No explicit type declared for '%s'"_err_en_US);
Say(name, "No explicit type declared for '%s'"_err_en_US, name.source);
return nullptr;
}
// Create the symbol, then ensure that it is accessible
Expand Down
7 changes: 7 additions & 0 deletions flang/test/Semantics/resolve40.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,10 @@ subroutine s12(x)
!BECAUSE: 'x' is an INTENT(IN) dummy argument
read(*,nml=nl)
end

subroutine s13()
implicit none
!ERROR: No explicit type declared for 'i'
!ERROR: No explicit type declared for 'i'
print *, (i, i = 1, 2)
end
Loading