[lldb][test] Fix TestChildCountTruncation on Windows #149322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not forcing the DWARF debug info format. When left as the default, the tests pass.
DavidSpickett
requested review from
Michael137
and removed request for
JDevlieghere
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesBy not forcing the DWARF debug info format. When left as the default, the tests pass. Test added by #149088. Full diff: https://github.com/llvm/llvm-project/pull/149322.diff 1 Files Affected:
diff --git a/lldb/test/Shell/Settings/TestChildCountTruncation.test b/lldb/test/Shell/Settings/TestChildCountTruncation.test
index 2660ccae1aa5b..da6436cb5ca20 100644
--- a/lldb/test/Shell/Settings/TestChildCountTruncation.test
+++ b/lldb/test/Shell/Settings/TestChildCountTruncation.test
@@ -1,11 +1,8 @@
# Test that we warn the user about truncated output
# when target.max-children-count wasn't explicitly set.
-# link.exe discards the DWARF information needed.
-# UNSUPPORTED: system-windows
-
# RUN: split-file %s %t
-# RUN: %clang_host -g -gdwarf %t/main.cpp -o %t.out
+# RUN: %clang_host -g %t/main.cpp -o %t.out
# RUN: %lldb -x -b -s %t/dwim-commands.input %t.out -o exit 2>&1 \
# RUN: | FileCheck %s --check-prefix=DWIM
#
|
|
@Michael137 Does this actually need DWARF, or will any debug info format do? |
|
nope doesn't need dwarf, thanks! |
Michael137
approved these changes
Jul 17, 2025
Michael137
added a commit
that referenced
this pull request
Jul 17, 2025
Fixes test on Windows. Same reason as #149322
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 17, 2025
Fixes test on Windows. Same reason as llvm/llvm-project#149322
Michael137
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jul 25, 2025
Fixes test on Windows. Same reason as llvm#149322 (cherry picked from commit b826429)
Michael137
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Jul 25, 2025
By not forcing the DWARF debug info format. When left as the default, the tests pass. Test added by llvm#149088. (cherry picked from commit 4bf82ae)
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Aug 15, 2025
Fixes test on Windows. Same reason as llvm#149322 (cherry picked from commit b826429)
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Aug 15, 2025
By not forcing the DWARF debug info format. When left as the default, the tests pass. Test added by llvm#149088. (cherry picked from commit 4bf82ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not forcing the DWARF debug info format. When left as the default, the tests pass.
Test added by #149088.