Skip to content

Conversation

@wenju-he
Copy link
Contributor

The implementation is based on reference implementation in OpenCL-CTS/test_integer_ops. The generic implementations pass OpenCL-CTS/test_integer_ops tests on Intel GPU.

…verse

The implementation is based on reference implementation in OpenCL-CTS/test_integer_ops.
The generic implementations pass OpenCL-CTS/test_integer_ops tests on Intel GPU.
@wenju-he wenju-he requested a review from frasercrmck July 16, 2025 10:45
Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of suggestions.

@frasercrmck frasercrmck added the libclc libclc OpenCL library label Jul 16, 2025
…ract.inc to clc_bitfield_extract_decl.inc, bitfield_extract.inc to bitfield_extract_decl.inc / bitfield_extract_def.inc
@wenju-he wenju-he requested a review from frasercrmck July 17, 2025 00:27
Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenju-he wenju-he merged commit c0294f4 into llvm:main Jul 18, 2025
9 checks passed
@wenju-he wenju-he deleted the libclc-bit-ops branch July 18, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libclc libclc OpenCL library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants