Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4842,11 +4842,94 @@ AMDGPUTargetLowering::foldFreeOpFromSelect(TargetLowering::DAGCombinerInfo &DCI,
return SDValue();
}

// Detect when CMP and SELECT use the same constant and fold them to avoid
// loading the constant twice. Specifically handles patterns like:
// %cmp = icmp eq i32 %val, 4242
// %sel = select i1 %cmp, i32 4242, i32 %other
// It can be optimized to reuse %val instead of 4242 in select.
static SDValue
foldCmpSelectWithSharedConstant(SDNode *N, TargetLowering::DAGCombinerInfo &DCI,
const AMDGPUSubtarget *ST) {
SDValue Cond = N->getOperand(0);
SDValue TrueVal = N->getOperand(1);
SDValue FalseVal = N->getOperand(2);

// Check if condition is a comparison.
if (Cond.getOpcode() != ISD::SETCC)
return SDValue();

SDValue LHS = Cond.getOperand(0);
SDValue RHS = Cond.getOperand(1);
ISD::CondCode CC = cast<CondCodeSDNode>(Cond.getOperand(2))->get();

bool isFloatingPoint = LHS.getValueType().isFloatingPoint();
bool isInteger = LHS.getValueType().isInteger();

// Handle simple floating-point and integer types only.
if (!isFloatingPoint && !isInteger)
return SDValue();

bool isEquality = CC == (isFloatingPoint ? ISD::SETOEQ : ISD::SETEQ);
bool isNonEquality = CC == (isFloatingPoint ? ISD::SETONE : ISD::SETNE);
if (!isEquality && !isNonEquality)
return SDValue();

SDValue ArgVal, ConstVal;
if ((isFloatingPoint && isa<ConstantFPSDNode>(RHS)) ||
(isInteger && isa<ConstantSDNode>(RHS))) {
ConstVal = RHS;
ArgVal = LHS;
} else if ((isFloatingPoint && isa<ConstantFPSDNode>(LHS)) ||
(isInteger && isa<ConstantSDNode>(LHS))) {
ConstVal = LHS;
ArgVal = RHS;
} else {
return SDValue();
}
Comment on lines +4878 to +4888
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The nested conditional logic for determining ConstVal and ArgVal could be simplified by extracting helper functions or using a more structured approach to reduce code duplication.

Suggested change
if ((isFloatingPoint && isa<ConstantFPSDNode>(RHS)) ||
(isInteger && isa<ConstantSDNode>(RHS))) {
ConstVal = RHS;
ArgVal = LHS;
} else if ((isFloatingPoint && isa<ConstantFPSDNode>(LHS)) ||
(isInteger && isa<ConstantSDNode>(LHS))) {
ConstVal = LHS;
ArgVal = RHS;
} else {
return SDValue();
}
std::tie(ConstVal, ArgVal) = getConstAndArgValues(LHS, RHS, isFloatingPoint, isInteger);
if (!ConstVal || !ArgVal)
return SDValue();

Copilot uses AI. Check for mistakes.

// Check if constant should not be optimized - early return if not.
if (isFloatingPoint) {
const APFloat &Val = cast<ConstantFPSDNode>(ConstVal)->getValueAPF();
const GCNSubtarget *GCNST = static_cast<const GCNSubtarget *>(ST);
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using dynamic_cast instead of static_cast for safer type conversion, or add an assertion to verify the cast is valid.

Suggested change
const GCNSubtarget *GCNST = static_cast<const GCNSubtarget *>(ST);
const GCNSubtarget *GCNST = dynamic_cast<const GCNSubtarget *>(ST);
if (!GCNST) {
// Return early if the cast is invalid
return SDValue();
}

Copilot uses AI. Check for mistakes.

// Only optimize normal floating-point values (finite, non-zero, and
// non-subnormal as per IEEE 754), skip optimization for inlinable
// floating-point constants.
if (!Val.isNormal() || GCNST->getInstrInfo()->isInlineConstant(Val))
return SDValue();
} else {
int64_t IntVal = cast<ConstantSDNode>(ConstVal)->getSExtValue();

// Skip optimization for inlinable integer immediates.
// Inlinable immediates include: -16 to 64 (inclusive).
if (IntVal >= -16 && IntVal <= 64)
return SDValue();
}

// For equality and non-equality comparisons, patterns:
// select (setcc x, const), const, y -> select (setcc x, const), x, y
// select (setccinv x, const), y, const -> select (setccinv x, const), y, x
if (!(isEquality && TrueVal == ConstVal) &&
!(isNonEquality && FalseVal == ConstVal))
return SDValue();

SDValue SelectLHS = (isEquality && TrueVal == ConstVal) ? ArgVal : TrueVal;
SDValue SelectRHS =
(isNonEquality && FalseVal == ConstVal) ? ArgVal : FalseVal;
return DCI.DAG.getNode(ISD::SELECT, SDLoc(N), N->getValueType(0), Cond,
SelectLHS, SelectRHS);
}

SDValue AMDGPUTargetLowering::performSelectCombine(SDNode *N,
DAGCombinerInfo &DCI) const {
if (SDValue Folded = foldFreeOpFromSelect(DCI, SDValue(N, 0)))
return Folded;

// Try to fold CMP + SELECT patterns with shared constants (both FP and
// integer).
if (SDValue Folded = foldCmpSelectWithSharedConstant(N, DCI, Subtarget))
return Folded;

SDValue Cond = N->getOperand(0);
if (Cond.getOpcode() != ISD::SETCC)
return SDValue();
Expand Down
Loading
Loading