-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[clang-tools-extra][NFC] Fix link to code review in README.txt #148384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) ChangesI'm not sure if we need to add label inside link or not, but Full diff: https://github.com/llvm/llvm-project/pull/148384.diff 1 Files Affected:
diff --git a/clang-tools-extra/README.txt b/clang-tools-extra/README.txt
index 6891e4078997f..7a0614facd835 100644
--- a/clang-tools-extra/README.txt
+++ b/clang-tools-extra/README.txt
@@ -11,9 +11,8 @@ All discussion regarding Clang, Clang-based tools, and code in this repository
should be held using the standard Clang forum:
https://discourse.llvm.org/c/clang
-Code review for this tree should take place on the standard Clang patch and
-commit lists:
- http://lists.llvm.org/mailman/listinfo/cfe-commits
+Code review for this tree should take place on Github:
+ https://github.com/llvm/llvm-project/pulls?q=label%3Aclang-tools-extra
If you find a bug in these tools, please file it in the LLVM bug tracker:
https://github.com/llvm/llvm-project/issues/
|
|
There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they should be mentioned explicitly? |
Added links to them as a list, do you think we need a new entry for each of the link? |
Yes, links are in comprehensible format. |
EugeneZelenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK for me, but please wait for other reviewers, I may miss something :-)
I'm not sure if we need to add label inside link or not, but
lists.llvm.orgseems outdated for sure, WDYT?