[lldb] fix incorrect logging message#146903
Merged
charles-zablit merged 1 commit intollvm:mainfrom Jul 3, 2025
Merged
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) ChangesFix an error message which incorrectly says that we failed to handle a Full diff: https://github.com/llvm/llvm-project/pull/146903.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
index f96fd0f0bcd30..77047c077c678 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
@@ -376,9 +376,9 @@ static bool PrintDemangledArgumentList(Stream &s, const SymbolContext &sc) {
auto info_or_err = GetAndValidateInfo(sc);
if (!info_or_err) {
- LLDB_LOG_ERROR(
- GetLog(LLDBLog::Language), info_or_err.takeError(),
- "Failed to handle ${{function.basename}} frame-format variable: {0}");
+ LLDB_LOG_ERROR(GetLog(LLDBLog::Language), info_or_err.takeError(),
+ "Failed to handle ${{function.formatted-arguments}} "
+ "frame-format variable: {0}");
return false;
}
auto [demangled_name, info] = *info_or_err;
|
Michael137
approved these changes
Jul 3, 2025
JDevlieghere
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an error message which incorrectly says that we failed to handle a
basename. It should sayformatted-argumentsinstead.